* [PATCH] mi: Use the value in mi_console_file->quote as the quoting character
@ 2014-04-26 22:10 Simon Marchi
2014-04-29 17:21 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2014-04-26 22:10 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
In mi_interpreter_init, multiple MI consoles/channels are created and a quoting
character is given. In mi_console_raw_packet, we check if the value is not 0
to decide if we should quote the string, but we don't use the value. It is
hardcoded to ". We might never use another quoting character than an actual
quote, but I suggest we change it, for correctness. There is not visible
behavior change.
I changed the latest fputs_unfiltered changed to fputc_unfiltered just to stay
consistent.
gdb/ChangeLog:
2014-04-26 Simon Marchi <simon.marchi@ericsson.com>
* mi/mi-console.c (mi_console_raw_packet): Use the value from
mi_console->quote as the quoting character.
---
gdb/mi/mi-console.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/gdb/mi/mi-console.c b/gdb/mi/mi-console.c
index dbad199..0880bd3 100644
--- a/gdb/mi/mi-console.c
+++ b/gdb/mi/mi-console.c
@@ -110,15 +110,16 @@ mi_console_raw_packet (void *data, const char *buf, long length_buf)
fputs_unfiltered (mi_console->prefix, mi_console->raw);
if (mi_console->quote)
{
- fputs_unfiltered ("\"", mi_console->raw);
+ fputc_unfiltered (mi_console->quote, mi_console->raw);
fputstrn_unfiltered (buf, length_buf,
mi_console->quote, mi_console->raw);
- fputs_unfiltered ("\"\n", mi_console->raw);
+ fputc_unfiltered (mi_console->quote, mi_console->raw);
+ fputc_unfiltered ('\n', mi_console->raw);
}
else
{
fputstrn_unfiltered (buf, length_buf, 0, mi_console->raw);
- fputs_unfiltered ("\n", mi_console->raw);
+ fputc_unfiltered ('\n', mi_console->raw);
}
gdb_flush (mi_console->raw);
}
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mi: Use the value in mi_console_file->quote as the quoting character
2014-04-26 22:10 [PATCH] mi: Use the value in mi_console_file->quote as the quoting character Simon Marchi
@ 2014-04-29 17:21 ` Tom Tromey
2014-05-12 19:42 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2014-04-29 17:21 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
Simon> 2014-04-26 Simon Marchi <simon.marchi@ericsson.com>
Simon> * mi/mi-console.c (mi_console_raw_packet): Use the value from
Simon> mi_console-> quote as the quoting character.
Thanks, this is ok.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mi: Use the value in mi_console_file->quote as the quoting character
2014-04-29 17:21 ` Tom Tromey
@ 2014-05-12 19:42 ` Simon Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2014-05-12 19:42 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On Tue 29 Apr 2014 01:21:11 PM EDT, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>
> Simon> 2014-04-26 Simon Marchi <simon.marchi@ericsson.com>
>
> Simon> * mi/mi-console.c (mi_console_raw_packet): Use the value from
> Simon> mi_console-> quote as the quoting character.
>
> Thanks, this is ok.
>
> Tom
I am pushing this.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-12 19:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-26 22:10 [PATCH] mi: Use the value in mi_console_file->quote as the quoting character Simon Marchi
2014-04-29 17:21 ` Tom Tromey
2014-05-12 19:42 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).