From: Pedro Alves <palves@redhat.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v2 1/3] btrace: control memory access during replay
Date: Tue, 20 May 2014 12:26:00 -0000 [thread overview]
Message-ID: <537B49DB.80609@redhat.com> (raw)
In-Reply-To: <1400587236-18836-1-git-send-email-markus.t.metzger@intel.com>
On 05/20/2014 01:00 PM, Markus Metzger wrote:
> The btrace record target does not trace data. We therefore do not allow
> accessing read-write memory during replay.
>
> In some cases, this might be useful to advanced users, though, who we assume
> to know what they are doing.
>
> Add a set|show command pair to turn this memory access restriction off.
>
The code bits are OK.
> + /* Record instructions number limit command. */
This comment looks like a pasto.
> + add_setshow_enum_cmd ("replay-memory-access", no_class,
> + replay_memory_access_types, &replay_memory_access, _("\
Thanks,
--
Pedro Alves
next prev parent reply other threads:[~2014-05-20 12:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 12:01 Markus Metzger
2014-05-20 12:00 ` [PATCH v2 2/3] test, gcore: move capture_command_output into lib/gdb.exp Markus Metzger
2014-05-20 12:27 ` Pedro Alves
2014-05-20 12:00 ` [PATCH v2 3/3] btrace, vdso: add vdso target sections Markus Metzger
2014-05-20 13:16 ` Pedro Alves
2014-05-20 14:10 ` Metzger, Markus T
2014-05-20 12:26 ` Pedro Alves [this message]
2014-05-20 16:12 ` [PATCH v2 1/3] btrace: control memory access during replay Eli Zaretskii
2014-05-21 6:10 ` Metzger, Markus T
2014-05-21 15:12 ` Eli Zaretskii
2014-05-22 6:12 ` Metzger, Markus T
2014-05-22 14:58 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537B49DB.80609@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).