From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6835 invoked by alias); 20 May 2014 12:26:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6817 invoked by uid 89); 20 May 2014 12:26:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 May 2014 12:26:12 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4KCQ5rt024724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 May 2014 08:26:08 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4KCQ3LM018992; Tue, 20 May 2014 08:26:04 -0400 Message-ID: <537B49DB.80609@redhat.com> Date: Tue, 20 May 2014 12:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Markus Metzger CC: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: [PATCH v2 1/3] btrace: control memory access during replay References: <1400587236-18836-1-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1400587236-18836-1-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00412.txt.bz2 On 05/20/2014 01:00 PM, Markus Metzger wrote: > The btrace record target does not trace data. We therefore do not allow > accessing read-write memory during replay. > > In some cases, this might be useful to advanced users, though, who we assume > to know what they are doing. > > Add a set|show command pair to turn this memory access restriction off. > The code bits are OK. > + /* Record instructions number limit command. */ This comment looks like a pasto. > + add_setshow_enum_cmd ("replay-memory-access", no_class, > + replay_memory_access_types, &replay_memory_access, _("\ Thanks, -- Pedro Alves