From: Simon Marchi <simon.marchi@ericsson.com>
To: Tom Tromey <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups
Date: Wed, 21 May 2014 17:34:00 -0000 [thread overview]
Message-ID: <537CE38B.7040000@ericsson.com> (raw)
In-Reply-To: <87mweh31qi.fsf@fleche.redhat.com>
On Fri 16 May 2014 04:30:45 PM EDT, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>
> Simon> This one was also from a year ago, I would like to make sure it is still
> Simon> OK.
>
> Simon> + if (inferior->has_exit_code)
> Simon> + ui_out_field_string (uiout, "exit-code",
> Simon> + int_string (inferior->exit_code, 8, 0, 0, 1));
>
> Why not the simpler ui_out_field_int?
> Going out of the way to print it in octal seems a bit odd for a machine
> interface.
>
> Tom
Agreed. I found that the exit code is often represented in octal (the
reason for this probably predates my birth). But for MI, it does not
matter.
Simon
next prev parent reply other threads:[~2014-05-21 17:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 21:56 Simon Marchi
2014-05-14 2:51 ` Eli Zaretskii
2014-05-16 20:31 ` Tom Tromey
2014-05-21 17:34 ` Simon Marchi [this message]
2014-05-21 18:09 ` Pedro Alves
2014-05-23 18:57 ` Simon Marchi
2014-06-02 18:30 ` Simon Marchi
2014-06-02 18:37 ` Eli Zaretskii
2014-06-02 19:23 ` Pedro Alves
2014-06-02 20:20 ` Simon Marchi
2014-06-03 15:27 ` Pedro Alves
2014-06-04 18:09 ` Tom Tromey
2014-09-29 21:43 ` Simon Marchi
2014-09-29 21:45 ` Simon Marchi
2014-09-30 2:36 ` Eli Zaretskii
2014-10-01 14:26 ` [PATCH v5][pushed] " Simon Marchi
2014-10-13 3:22 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537CE38B.7040000@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).