* [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c
@ 2014-05-22 9:07 Ramana Radhakrishnan
2014-05-22 12:49 ` Joel Brobecker
0 siblings, 1 reply; 6+ messages in thread
From: Ramana Radhakrishnan @ 2014-05-22 9:07 UTC (permalink / raw)
To: gdb-patches; +Cc: Marcus Shawcroft
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
Hi,
A recent change to glibc removed asm/ptrace.h from user.h for AArch64.
This meant that cross-native builds of gdb using trunk glibc broke
because aarch64-linux-nat.c because user_hwdebug_state couldn't be found.
Fixed by including asm/ptrace.h like other ports.
Ok ?
regards
Ramana
2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
* aarch64-linux-nat.c (asm/ptrace.h): Include.
[-- Attachment #2: p1.txt --]
[-- Type: text/plain, Size: 868 bytes --]
commit 53278fc086b53264d75ec9cb2a4929565276100a
Author: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
Date: Thu May 22 09:41:41 2014 +0100
Include asm/ptrace.h for recent glibc changes.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6f5c9c2..95df3e1 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
+ * aarch64-linux-nat.c (asm/ptrace.h): Include.
+
+2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
+
* MAINTAINERS (Write After Approval): Move self back from
Paper trail.
diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
index 28ad38b..877e702 100644
--- a/gdb/aarch64-linux-nat.c
+++ b/gdb/aarch64-linux-nat.c
@@ -33,6 +33,7 @@
#include <sys/ptrace.h>
#include <sys/utsname.h>
+#include <asm/ptrace.h>
#include "gregset.h"
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c
2014-05-22 9:07 [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c Ramana Radhakrishnan
@ 2014-05-22 12:49 ` Joel Brobecker
2014-05-22 15:43 ` Ramana Radhakrishnan
2014-05-23 8:04 ` Ramana Radhakrishnan
0 siblings, 2 replies; 6+ messages in thread
From: Joel Brobecker @ 2014-05-22 12:49 UTC (permalink / raw)
To: Ramana Radhakrishnan; +Cc: gdb-patches, Marcus Shawcroft
> A recent change to glibc removed asm/ptrace.h from user.h for
> AArch64. This meant that cross-native builds of gdb using trunk
> glibc broke because aarch64-linux-nat.c because user_hwdebug_state
> couldn't be found.
>
> Fixed by including asm/ptrace.h like other ports.
Thanks for the explanation. Can you make sure you include that
in the revision history of your commit?
> 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>
> * aarch64-linux-nat.c (asm/ptrace.h): Include.
>
OK to push. Thank you.
> commit 53278fc086b53264d75ec9cb2a4929565276100a
> Author: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
> Date: Thu May 22 09:41:41 2014 +0100
>
> Include asm/ptrace.h for recent glibc changes.
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 6f5c9c2..95df3e1 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,5 +1,9 @@
> 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>
> + * aarch64-linux-nat.c (asm/ptrace.h): Include.
> +
> +2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
> +
> * MAINTAINERS (Write After Approval): Move self back from
> Paper trail.
>
> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
> index 28ad38b..877e702 100644
> --- a/gdb/aarch64-linux-nat.c
> +++ b/gdb/aarch64-linux-nat.c
> @@ -33,6 +33,7 @@
>
> #include <sys/ptrace.h>
> #include <sys/utsname.h>
> +#include <asm/ptrace.h>
>
> #include "gregset.h"
>
--
Joel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c
2014-05-22 12:49 ` Joel Brobecker
@ 2014-05-22 15:43 ` Ramana Radhakrishnan
2014-05-23 8:04 ` Ramana Radhakrishnan
1 sibling, 0 replies; 6+ messages in thread
From: Ramana Radhakrishnan @ 2014-05-22 15:43 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches, Marcus Shawcroft
On 05/22/14 13:49, Joel Brobecker wrote:
>> A recent change to glibc removed asm/ptrace.h from user.h for
>> AArch64. This meant that cross-native builds of gdb using trunk
>> glibc broke because aarch64-linux-nat.c because user_hwdebug_state
>> couldn't be found.
>>
>> Fixed by including asm/ptrace.h like other ports.
>
> Thanks for the explanation. Can you make sure you include that
> in the revision history of your commit?
>
>> 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>>
>> * aarch64-linux-nat.c (asm/ptrace.h): Include.
>>
>
> OK to push. Thank you.
Thanks, pushed.
Ramana
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c
2014-05-22 12:49 ` Joel Brobecker
2014-05-22 15:43 ` Ramana Radhakrishnan
@ 2014-05-23 8:04 ` Ramana Radhakrishnan
2014-05-23 12:17 ` Richard Earnshaw
1 sibling, 1 reply; 6+ messages in thread
From: Ramana Radhakrishnan @ 2014-05-23 8:04 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches, Marcus Shawcroft
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
On 05/22/14 13:49, Joel Brobecker wrote:
>> A recent change to glibc removed asm/ptrace.h from user.h for
>> AArch64. This meant that cross-native builds of gdb using trunk
>> glibc broke because aarch64-linux-nat.c because user_hwdebug_state
>> couldn't be found.
>>
>> Fixed by including asm/ptrace.h like other ports.
>
> Thanks for the explanation. Can you make sure you include that
> in the revision history of your commit?
>
>> 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>>
>> * aarch64-linux-nat.c (asm/ptrace.h): Include.
>>
>
> OK to push. Thank you.
>
>
Thanks - I've got a similar one in gdbserver which I somehow managed to
miss yesterday.
Ok to push ?
regards
Ramana
[-- Attachment #2: p1.txt --]
[-- Type: text/plain, Size: 1388 bytes --]
commit e9dae05e9c32efda9724330c6d5ade3ca848591d
Author: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
Date: Fri May 23 09:01:14 2014 +0100
Include asm/ptrace.h for linux-aarch64-low.c
A recent change to glibc removed asm/ptrace.h from user.h for AArch64.
This meant that cross-native builds of gdbserver using trunk glibc broke
because linux-aarch64-low.c because user_hwdebug_state couldn't be found.
This is like commit #036cd38182bde32d8297b630cd5c861d53b8949e
2014-05-23 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
* linux-aarch64-low.c (asm/ptrace.h): Include.
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 81bd30e..e591108 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,7 @@
+2014-05-23 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
+
+ * linux-aarch64-low.c (asm/ptrace.h): Include.
+
2014-05-21 Jan Kratochvil <jan.kratochvil@redhat.com>
Fix TLS access for -static -pthread.
diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
index 033e79e..6066e15 100644
--- a/gdb/gdbserver/linux-aarch64-low.c
+++ b/gdb/gdbserver/linux-aarch64-low.c
@@ -26,6 +26,7 @@
#include <signal.h>
#include <sys/user.h>
#include <sys/ptrace.h>
+#include <asm/ptrace.h>
#include <sys/uio.h>
#include "gdb_proc_service.h"
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c
2014-05-23 8:04 ` Ramana Radhakrishnan
@ 2014-05-23 12:17 ` Richard Earnshaw
2014-05-23 12:45 ` Joel Brobecker
0 siblings, 1 reply; 6+ messages in thread
From: Richard Earnshaw @ 2014-05-23 12:17 UTC (permalink / raw)
To: Ramana Radhakrishnan; +Cc: Joel Brobecker, gdb-patches, Marcus Shawcroft
On 23/05/14 09:03, Ramana Radhakrishnan wrote:
> On 05/22/14 13:49, Joel Brobecker wrote:
>>> A recent change to glibc removed asm/ptrace.h from user.h for
>>> AArch64. This meant that cross-native builds of gdb using trunk
>>> glibc broke because aarch64-linux-nat.c because user_hwdebug_state
>>> couldn't be found.
>>>
>>> Fixed by including asm/ptrace.h like other ports.
>>
>> Thanks for the explanation. Can you make sure you include that
>> in the revision history of your commit?
>>
>>> 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>>>
>>> * aarch64-linux-nat.c (asm/ptrace.h): Include.
>>>
>>
>> OK to push. Thank you.
>>
>>
>
> Thanks - I've got a similar one in gdbserver which I somehow managed to
> miss yesterday.
>
> Ok to push ?
>
I'd be inclined to consider this as obvious after yesterday's approval.
R.
> regards
> Ramana
>
>
>
> p1.txt
>
>
> commit e9dae05e9c32efda9724330c6d5ade3ca848591d
> Author: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
> Date: Fri May 23 09:01:14 2014 +0100
>
> Include asm/ptrace.h for linux-aarch64-low.c
>
> A recent change to glibc removed asm/ptrace.h from user.h for AArch64.
> This meant that cross-native builds of gdbserver using trunk glibc broke
> because linux-aarch64-low.c because user_hwdebug_state couldn't be found.
>
> This is like commit #036cd38182bde32d8297b630cd5c861d53b8949e
>
> 2014-05-23 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>
> * linux-aarch64-low.c (asm/ptrace.h): Include.
>
> diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
> index 81bd30e..e591108 100644
> --- a/gdb/gdbserver/ChangeLog
> +++ b/gdb/gdbserver/ChangeLog
> @@ -1,3 +1,7 @@
> +2014-05-23 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
> +
> + * linux-aarch64-low.c (asm/ptrace.h): Include.
> +
> 2014-05-21 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix TLS access for -static -pthread.
> diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
> index 033e79e..6066e15 100644
> --- a/gdb/gdbserver/linux-aarch64-low.c
> +++ b/gdb/gdbserver/linux-aarch64-low.c
> @@ -26,6 +26,7 @@
> #include <signal.h>
> #include <sys/user.h>
> #include <sys/ptrace.h>
> +#include <asm/ptrace.h>
> #include <sys/uio.h>
>
> #include "gdb_proc_service.h"
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c
2014-05-23 12:17 ` Richard Earnshaw
@ 2014-05-23 12:45 ` Joel Brobecker
0 siblings, 0 replies; 6+ messages in thread
From: Joel Brobecker @ 2014-05-23 12:45 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: Ramana Radhakrishnan, gdb-patches, Marcus Shawcroft
> >>> 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
> >>>
> >>> * aarch64-linux-nat.c (asm/ptrace.h): Include.
> >>>
> >>
> >> OK to push. Thank you.
> >>
> >>
> >
> > Thanks - I've got a similar one in gdbserver which I somehow managed to
> > miss yesterday.
> >
> > Ok to push ?
Yep!
> I'd be inclined to consider this as obvious after yesterday's approval.
I agree.
--
Joel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-23 12:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-22 9:07 [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c Ramana Radhakrishnan
2014-05-22 12:49 ` Joel Brobecker
2014-05-22 15:43 ` Ramana Radhakrishnan
2014-05-23 8:04 ` Ramana Radhakrishnan
2014-05-23 12:17 ` Richard Earnshaw
2014-05-23 12:45 ` Joel Brobecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).