From: Simon Marchi <simon.marchi@polymtl.ca>
To: Christian Biesinger <cbiesinger@google.com>
Cc: Simon Marchi <simon.marchi@efficios.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/4] gdb: add intern method to objfile_per_bfd_storage
Date: Tue, 23 Mar 2021 12:08:14 -0400 [thread overview]
Message-ID: <537cfcda-4b1b-fecf-628f-248b4274a44f@polymtl.ca> (raw)
In-Reply-To: <CAPTJ0XHwRfak_OFiaeJwCAJfbHHXqNbDXfZYgNa4HnJRG7Tn=Q@mail.gmail.com>
>> From what I remember from last time something like this came up (I can't
>> remember the context) is that we'd only use string_view for strings that
>> are null-terminated, even though string_view doesn't guarantee it. Is
>> that the case? Or is it a bad use case for string_view?
>
> Hm, I'm not sure we concluded that in the general case. It came up
> specifically for general_symbol_info::compute_and_set_names, which can
> handle the case where it may or may not be nullterminated depending on
> a parameter. IMO you should at least comment that the string view must
> be nullterminated here.
Good idea, will do.
Simon
next prev parent reply other threads:[~2021-03-23 16:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 19:34 [PATCH 0/4] Small Misc psymtabs / objfile cleanups Simon Marchi
2021-03-22 19:34 ` [PATCH 1/4] gdb: add intern method to objfile_per_bfd_storage Simon Marchi
2021-03-23 14:47 ` Christian Biesinger
2021-03-23 15:48 ` Simon Marchi
2021-03-23 15:53 ` Christian Biesinger
2021-03-23 16:08 ` Simon Marchi [this message]
2021-04-01 17:44 ` Tom Tromey
2021-04-02 15:38 ` Simon Marchi
2021-03-22 19:34 ` [PATCH 2/4] gdb: use std::string in partial_symtab::partial_symtab / allocate_symtab Simon Marchi
2021-04-01 17:43 ` Tom Tromey
2021-03-22 19:34 ` [PATCH 3/4] gdb: pass objfile_per_bfd_storage instead of objfile to partial_symtab Simon Marchi
2021-04-01 17:47 ` Tom Tromey
2021-04-02 15:42 ` Simon Marchi
2021-03-22 19:34 ` [PATCH 4/4] gdb: remove objfile parameter from get_objfile_bfd_data Simon Marchi
2021-04-01 17:52 ` Tom Tromey
2021-04-02 15:52 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537cfcda-4b1b-fecf-628f-248b4274a44f@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).