From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 662F5385701F for ; Tue, 23 Mar 2021 16:08:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 662F5385701F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12NG8ELo020435 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Mar 2021 12:08:19 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12NG8ELo020435 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B92AA1E939; Tue, 23 Mar 2021 12:08:14 -0400 (EDT) Subject: Re: [PATCH 1/4] gdb: add intern method to objfile_per_bfd_storage To: Christian Biesinger Cc: Simon Marchi , gdb-patches References: <20210322193417.2376788-1-simon.marchi@efficios.com> <20210322193417.2376788-2-simon.marchi@efficios.com> <13c62035-c0e2-06cf-aeb7-4ae515b90c27@polymtl.ca> From: Simon Marchi Message-ID: <537cfcda-4b1b-fecf-628f-248b4274a44f@polymtl.ca> Date: Tue, 23 Mar 2021 12:08:14 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 23 Mar 2021 16:08:14 +0000 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 16:08:23 -0000 >> From what I remember from last time something like this came up (I can't >> remember the context) is that we'd only use string_view for strings that >> are null-terminated, even though string_view doesn't guarantee it. Is >> that the case? Or is it a bad use case for string_view? > > Hm, I'm not sure we concluded that in the general case. It came up > specifically for general_symbol_info::compute_and_set_names, which can > handle the case where it may or may not be nullterminated depending on > a parameter. IMO you should at least comment that the string view must > be nullterminated here. Good idea, will do. Simon