From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10876 invoked by alias); 27 May 2014 06:34:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10863 invoked by uid 89); 27 May 2014 06:34:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: qmta05.emeryville.ca.mail.comcast.net Received: from qmta05.emeryville.ca.mail.comcast.net (HELO qmta05.emeryville.ca.mail.comcast.net) (76.96.30.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 May 2014 06:34:38 +0000 Received: from omta10.emeryville.ca.mail.comcast.net ([76.96.30.28]) by qmta05.emeryville.ca.mail.comcast.net with comcast id 6uXp1o0030cQ2SLA5uadlo; Tue, 27 May 2014 06:34:37 +0000 Received: from redwood.eagercon.com ([24.7.16.38]) by omta10.emeryville.ca.mail.comcast.net with comcast id 6uab1o00M0pGQcg8WuacB9; Tue, 27 May 2014 06:34:36 +0000 Message-ID: <538431FB.2070904@eagercon.com> Date: Tue, 27 May 2014 06:34:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ajit Kumar Agarwal , "gdb-patches@sourceware.org" , Yao Qi , Pedro Alves CC: Joel Brobecker , Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch, microblaze]: Add slr and shr regs References: <537EFA08.1060309@eagercon.com> <537FCEDA.9030504@eagercon.com> <2e5c185d-329c-46cf-930c-8cc2288891aa@BN1BFFO11FD019.protection.gbl> In-Reply-To: <2e5c185d-329c-46cf-930c-8cc2288891aa@BN1BFFO11FD019.protection.gbl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00646.txt.bz2 On 05/26/14 03:04, Ajit Kumar Agarwal wrote: > > Based on the feedback and incorporated all review comment, updated the patch. > > [Patch, microblaze]: Add slr and shr regs > > Prior to version x.xx, XMD's gdbserver stub returned 57 registers in > response to GDB's G request. Starting with version x.xx, XMD added the > slr and shr register, for a count of 59 registers. This patch adds > these registers to the expected G response What versions? What targets have you built and tested? > > ChangeLog: > 2014-05-26 Ajit Agarwal > > * Makefile.in (microblaze-linux.c): New rule. > > * microblaze-tdep.c (microblaze_register_names): Add > the rshr and rslr register names. > > * microblaze-tdep.h (microblaze_reg_num): Add > field MICROBLAZE_SLR_REGNUM and MICROBLAZE_SHR_REGNUM > MICROBLAZE_NUM_REGS. > (microblaze_frame_cache): Use of MICROBLAZE_NUM_REGS. > > * features/microblaze-cpu.xml: New file. > > * features/microblaze-linux.c: New file. > > * features/microblaze-linux.xml: New file. > > * regformats/reg-microblaze.dat: New file. > > * features/Makefile (microblaze-linux): Add > microblaze-linux and microblaze-expedite. > > Signed-off-by:Ajit Agarwal ajitkum@xilinx.com > > Thanks & Regards > Ajit > -----Original Message----- > From: Michael Eager [mailto:eager@eagercon.com] > Sent: Saturday, May 24, 2014 4:13 AM > To: Ajit Kumar Agarwal; gdb-patches@sourceware.org > Cc: Joel Brobecker; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala > Subject: Re: [Patch, microblaze]: Add slr and shr regs > > On 05/23/14 02:46, Ajit Kumar Agarwal wrote: >> >> >>>> Let's try this one more time: GDB is connected to something when you tell it to connect to the target with the "target remote" command. >>>> This is returning a different sized G packet. What is it that you are connecting to? >> >> Here is the flow from GBD Client to XMD that's what is happening: >> >> 1. XMD connects to the hardware target through JTAG. >> 2. XMD Opens a GDB Server on the local host 1234. >> 3. GDB Client will connect to the host:1234 through TCP, when the command "tar remote localhost:1234" is given. > > Ajit -- > > Let me suggest this description of the problem: > Prior to version x.xx, XMD's gdbserver stub returned 57 registers in > response to GDB's G request. Starting with version x.xx, XMD added the > slr and shr register, for a count of 59 registers. This patch adds > these registers to the expected G response. > > Please resubmit the patch, in full, with ChangeLog. > > -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077