From: Pedro Alves <palves@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Hui Zhu <hui_zhu@mentor.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix ptype.exp fail in MIPS
Date: Tue, 27 May 2014 18:15:00 -0000 [thread overview]
Message-ID: <5384D643.1070707@redhat.com> (raw)
In-Reply-To: <CANFwon3zoYs8ZJO4HGHc+bAR+eRUQSt2A-CcdwtVq8e9v3Cd+A@mail.gmail.com>
On 05/16/2014 08:40 AM, Hui Zhu wrote:
> On Fri, May 16, 2014 at 1:53 AM, Pedro Alves <palves@redhat.com> wrote:
>> On 05/13/2014 05:09 AM, Hui Zhu wrote:
>>> ptype $pc
>>> type = int32_t
>>> (gdb) FAIL: gdb.base/ptype.exp: ptype $pc
>>> This is because the $pc register in MIPS is set to int but not code_ptr.
>>> And according to the discussion in
>>> https://sourceware.org/ml/gdb/2013-06/msg00020.html, the type cannot be
>>> changed.
>>
>> Hmm, that's not what I get from this branch of the discussion:
>>
>> https://sourceware.org/ml/gdb/2013-06/msg00021.html
>>
>> --
>
> https://sourceware.org/ml/gdb/2013-06/msg00032.html
That was an alternative proposal, but nobody replied saying
it was a great idea, so I don't know. The main disadvantage
is that the user would have to know about these different
registers, which may be confusing and obscure.
> Do you think add ptr64 or $_xx is OK for you to handle this issue?
I'm leaning torwards ptr64. Anyone see a reason why that wouldn't work?
That was also sort of agreed upon by both Mark and Maciej at:
https://sourceware.org/ml/gdb/2013-06/msg00029.html
"
> Overall I think the test is too strict. If you think the use of "long
> long" is unfortunate for the PC, then an artificial type might be created
> internally within GDB specifically for the PC, similarly to what we do
> e.g. for IEEE 754 data types and floating-point registers in some cases.
An artificial type like that probably is the way to go.
"
But of course that was a while ago and they might have changed
their minds since.
--
Pedro Alves
next prev parent reply other threads:[~2014-05-27 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 4:10 Hui Zhu
2014-05-15 17:26 ` Tom Tromey
2014-05-15 17:53 ` Pedro Alves
2014-05-16 7:41 ` Hui Zhu
2014-05-19 14:51 ` Doug Evans
2014-05-27 8:53 ` Hui Zhu
2014-05-27 18:25 ` Pedro Alves
2014-05-27 18:15 ` Pedro Alves [this message]
2014-05-27 21:52 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5384D643.1070707@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hui_zhu@mentor.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).