From: Pedro Alves <palves@redhat.com>
To: Doug Evans <xdje42@gmail.com>, Hui Zhu <teawater@gmail.com>
Cc: Hui Zhu <hui_zhu@mentor.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix ptype.exp fail in MIPS
Date: Tue, 27 May 2014 18:25:00 -0000 [thread overview]
Message-ID: <5384D8A9.1060404@redhat.com> (raw)
In-Reply-To: <CAP9bCMQ-JM=2DKCywZkn6=qOWtZnB8DPkLpkNuJDK2DtaGeBLw@mail.gmail.com>
On 05/19/2014 03:51 PM, Doug Evans wrote:
> On Fri, May 16, 2014 at 12:40 AM, Hui Zhu <teawater@gmail.com> wrote:
>> On Fri, May 16, 2014 at 1:53 AM, Pedro Alves <palves@redhat.com> wrote:
>>> On 05/13/2014 05:09 AM, Hui Zhu wrote:
>>>> ptype $pc
>>>> type = int32_t
>>>> (gdb) FAIL: gdb.base/ptype.exp: ptype $pc
>>>> This is because the $pc register in MIPS is set to int but not code_ptr.
>>>> And according to the discussion in
>>>> https://sourceware.org/ml/gdb/2013-06/msg00020.html, the type cannot be
>>>> changed.
>>>
>>> Hmm, that's not what I get from this branch of the discussion:
>>>
>>> https://sourceware.org/ml/gdb/2013-06/msg00021.html
>>>
>>> --
>>
>> https://sourceware.org/ml/gdb/2013-06/msg00032.html
>> Do you think add ptr64 or $_xx is OK for you to handle this issue?
>
> IIUC it's not just adding $_xx but changing the type of $pc so that
> ptype.exp will pass as is.
> Is that correct?
Yeah. As listed at the bottom of that url, $pc would be
changed to be the ABI function pointer width (32-bit pointer),
as a pseudo-register, and $_pc/$rNN would be mapped to the
machine's full 64-bit contents, as an integer.
I'm not certain this is a good idea of not in terms of user
interface. I know _I_ wouldn't be confused, and I know I have
been confused by $sp/$esp/$rsp on x86 before ($sp is not really
what one would expect if one doesn't know about GDB's special
magic stack pointer register), but I'm not really representative
of a regular gdb user.
--
Pedro Alves
next prev parent reply other threads:[~2014-05-27 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 4:10 Hui Zhu
2014-05-15 17:26 ` Tom Tromey
2014-05-15 17:53 ` Pedro Alves
2014-05-16 7:41 ` Hui Zhu
2014-05-19 14:51 ` Doug Evans
2014-05-27 8:53 ` Hui Zhu
2014-05-27 18:25 ` Pedro Alves [this message]
2014-05-27 18:15 ` Pedro Alves
2014-05-27 21:52 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5384D8A9.1060404@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hui_zhu@mentor.com \
--cc=teawater@gmail.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).