From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-112860-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27658 invoked by alias); 28 May 2014 18:42:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 27642 invoked by uid 89); 28 May 2014 18:42:07 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 May 2014 18:42:06 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4SIg5Y4007536	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 28 May 2014 14:42:05 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s4SIg3Ag017500;	Wed, 28 May 2014 14:42:04 -0400
Message-ID: <53862DFB.80102@redhat.com>
Date: Wed, 28 May 2014 18:42:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Andrew Burgess <aburgess@broadcom.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 1/4] New test for backtrace when the stack pointer is invalid (inaccessible).
References: <533EC5B7.6080600@broadcom.com> <1398855344-25278-1-git-send-email-aburgess@broadcom.com> <1398855344-25278-2-git-send-email-aburgess@broadcom.com>
In-Reply-To: <1398855344-25278-2-git-send-email-aburgess@broadcom.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-05/txt/msg00698.txt.bz2

On 04/30/2014 11:55 AM, Andrew Burgess wrote:

> +
> +#include <sys/mman.h>
> +#include <unistd.h>
> +#include <assert.h>
> +
> +void
> +breakpt ()

'(void)' here and elsewhere.

> +int
> +main ()

Otherwise looks fine.

(I'd have slightly preferred that the patch
for the crash included the test, adjusted as necessary, and
then the follow up patches added / built on the existing test.)

Thanks,
-- 
Pedro Alves