From: Michael Eager <eager@eagercon.com>
To: Ajit Kumar Agarwal <ajit.kumar.agarwal@xilinx.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Yao Qi <yao@codesourcery.com>, Pedro Alves <palves@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
Vinod Kathail <vinodk@xilinx.com>,
Vidhumouli Hunsigida <vidhum@xilinx.com>,
Nagaraju Mekala <nmekala@xilinx.com>
Subject: Re: [Patch, microblaze]: Add slr and shr regs
Date: Thu, 29 May 2014 07:20:00 -0000 [thread overview]
Message-ID: <5386DFA0.1040006@eagercon.com> (raw)
In-Reply-To: <865132b2-a593-4147-a7c6-cee25c1ed0fd@BN1AFFO11FD052.protection.gbl>
On 05/27/14 00:46, Ajit Kumar Agarwal wrote:
>
>
> -----Original Message-----
> From: Michael Eager [mailto:eager@eagercon.com]
> Sent: Tuesday, May 27, 2014 12:05 PM
> To: Ajit Kumar Agarwal; gdb-patches@sourceware.org; Yao Qi; Pedro Alves
> Cc: Joel Brobecker; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
> Subject: Re: [Patch, microblaze]: Add slr and shr regs
>
> On 05/26/14 03:04, Ajit Kumar Agarwal wrote:
>>
>> Based on the feedback and incorporated all review comment, updated the patch.
>>
>> [Patch, microblaze]: Add slr and shr regs
>>
>> Prior to version x.xx, XMD's gdbserver stub returned 57 registers in
>> response to GDB's G request. Starting with version x.xx, XMD added the
>> slr and shr register, for a count of 59 registers. This patch adds
>> these registers to the expected G response
>
>>> What versions?
>
> Update the problem description and here it is.
>
> [Patch, microblaze]: Add slr and shr regs
>
> Prior to version 2013.1, XMD's gdbserver stub returned 57 registers in
> response to GDB's G request. Starting with version 2013.1, XMD added the
> slr and shr register, for a count of 59 registers. This patch adds
> these registers to the expected G response.
I'm not familiar with this version numbering. Is this an internal number?
Is this displayed by XMD? Which version of EDK does this correspond to?
>
>>> What targets have you built and tested?
>
> Microblaze target has been built and tested.
Exactly which --target triples were built and tested?
Please make sure that --target=microblaze-xilinx-elf
has been built and tested.
>
>>
>> ChangeLog:
>> 2014-05-26 Ajit Agarwal <ajitkum@xilinx.com>
>>
>> * Makefile.in (microblaze-linux.c): New rule.
>>
>> * microblaze-tdep.c (microblaze_register_names): Add
>> the rshr and rslr register names.
>>
>> * microblaze-tdep.h (microblaze_reg_num): Add
>> field MICROBLAZE_SLR_REGNUM and MICROBLAZE_SHR_REGNUM
>> MICROBLAZE_NUM_REGS.
>> (microblaze_frame_cache): Use of MICROBLAZE_NUM_REGS.
>>
>> * features/microblaze-cpu.xml: New file.
>>
>> * features/microblaze-linux.c: New file.
>>
>> * features/microblaze-linux.xml: New file.
>>
>> * regformats/reg-microblaze.dat: New file.
>>
>> * features/Makefile (microblaze-linux): Add
>> microblaze-linux and microblaze-expedite.
>>
>> Signed-off-by:Ajit Agarwal ajitkum@xilinx.com
>>
>> Thanks & Regards
>> Ajit
>> -----Original Message-----
>> From: Michael Eager [mailto:eager@eagercon.com]
>> Sent: Saturday, May 24, 2014 4:13 AM
>> To: Ajit Kumar Agarwal; gdb-patches@sourceware.org
>> Cc: Joel Brobecker; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
>> Subject: Re: [Patch, microblaze]: Add slr and shr regs
>>
>> On 05/23/14 02:46, Ajit Kumar Agarwal wrote:
>>>
>>>
>>>>> Let's try this one more time: GDB is connected to something when you tell it to connect to the target with the "target remote" command.
>>>>> This is returning a different sized G packet. What is it that you are connecting to?
>>>
>>> Here is the flow from GBD Client to XMD that's what is happening:
>>>
>>> 1. XMD connects to the hardware target through JTAG.
>>> 2. XMD Opens a GDB Server on the local host 1234.
>>> 3. GDB Client will connect to the host:1234 through TCP, when the command "tar remote localhost:1234" is given.
>>
>> Ajit --
>>
>> Let me suggest this description of the problem:
>> Prior to version x.xx, XMD's gdbserver stub returned 57 registers in
>> response to GDB's G request. Starting with version x.xx, XMD added the
>> slr and shr register, for a count of 59 registers. This patch adds
>> these registers to the expected G response.
>>
>> Please resubmit the patch, in full, with ChangeLog.
>>
>>
>
>
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2014-05-29 7:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 6:54 Ajit Kumar Agarwal
2014-05-23 7:34 ` Michael Eager
2014-05-23 9:47 ` Ajit Kumar Agarwal
2014-05-23 22:42 ` Michael Eager
2014-05-26 10:04 ` Ajit Kumar Agarwal
2014-05-27 6:34 ` Michael Eager
2014-05-27 7:46 ` Ajit Kumar Agarwal
2014-05-27 8:53 ` Pedro Alves
2014-06-09 17:26 ` Ajit Kumar Agarwal
2014-06-09 17:57 ` Pedro Alves
2014-06-09 19:35 ` Ajit Kumar Agarwal
2014-05-29 7:20 ` Michael Eager [this message]
2014-06-05 15:54 ` Michael Eager
2014-06-09 17:26 ` Ajit Kumar Agarwal
2014-06-09 18:28 ` Michael Eager
2014-06-09 19:31 ` Ajit Kumar Agarwal
2014-06-09 20:06 ` Michael Eager
2014-06-10 13:51 ` Ajit Kumar Agarwal
2014-06-10 14:12 ` Michael Eager
2014-06-10 14:49 ` Ajit Kumar Agarwal
2014-06-10 15:27 ` Michael Eager
2014-06-12 8:34 ` Ajit Kumar Agarwal
2014-05-23 8:32 ` Yao Qi
2014-05-23 20:33 ` Ajit Kumar Agarwal
2014-05-23 8:44 ` Pedro Alves
2014-05-23 20:36 ` Ajit Kumar Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5386DFA0.1040006@eagercon.com \
--to=eager@eagercon.com \
--cc=ajit.kumar.agarwal@xilinx.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=nmekala@xilinx.com \
--cc=palves@redhat.com \
--cc=vidhum@xilinx.com \
--cc=vinodk@xilinx.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).