On 05/13/2014 10:35 AM, Vladimir Prus wrote:
> On 05/08/2014 10:04 PM, Keith Seitz wrote:
>> +    {"s", EXPLICIT_SOURCE_OPT, 1},
>> +    {"m", EXPLICIT_FUNC_OPT, 1},
>> +    {"l", EXPLICIT_LABEL_OPT, 1},
>> +    {"o", EXPLICIT_LINE_OPT, 1},
>
> Maybe it's me, but 'm' and 'o' do not appear like logical abbreviation.

Those letters were refinements based on previous feedback. m = method, l 
= label, o = offset (which is what "line" really is; it is both relative 
and absolute values; it's also what it's called internally).

I was just following the existing conventions:

  static const struct mi_opt opts[] =
   {
     {"h", HARDWARE_OPT, 0},
     {"t", TEMP_OPT, 0},
     {"c", CONDITION_OPT, 1},
     {"i", IGNORE_COUNT_OPT, 1},
     {"p", THREAD_OPT, 1},
     {"f", PENDING_OPT, 0},
     {"d", DISABLE_OPT, 0},
     {"a", TRACEPOINT_OPT, 0},
     { 0, 0, 0 }

I didn't find m and o any less logical than "p", "f", or "a". In the 
end, though, since none of this matters to a machine, I simply picked 
something semi-logical. At least to me. :-)

> Maybe, it's time to just switch to fully-spelled option names?

I can do that. Do you want me to submit a patch to add long aliases for 
the existing options?

The proposed list of options would then be:
Current: h, t, c, i, p, f, d, a
New aliases: hardware, temporary, condition, ignorecount, thread, 
pending, disable, tracepoint
New explicit locations: source, function, label, line

I've updated the patch and changed the explicit options to those listed 
immediately above.

Thank you for the feedback!
Keith

Changes since last version:
8-ui-mi:
   - use --source, --function, --label, --line instead of
     "-s", "-m", "-l", "-o"
   - update tests

ChangeLog
2014-05-29  Keith Seitz  <keiths@redhat.com>

	* mi/mi-cmd-break.c (mi_cmd_break_insert_1): Add support for
	explicit locations, options "--source", "--function",
	"--label", and "--line".

testsuite/ChangeLog
2014-05-29  Keith Seitz  <keiths@redhat.com>

	* gdb.mi/mi-break.exp (test_explicit_breakpoints): New proc.
	(at toplevel): Call test_explicit_breakpoints.
	* gdb.mi/mi-dprintf.exp: Add tests for explicit dprintf
	breakpoints.
	* lib/mi-support.exp (mi_make_breakpoint): Add support for
	breakpoint conditions, "-cond".