From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24588 invoked by alias); 3 Jun 2014 05:35:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24578 invoked by uid 89); 3 Jun 2014 05:35:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Jun 2014 05:35:03 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WrhNE-00003o-MX from Yao_Qi@mentor.com ; Mon, 02 Jun 2014 22:35:00 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 2 Jun 2014 22:35:00 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Mon, 2 Jun 2014 22:34:59 -0700 Message-ID: <538D5E05.2000807@codesourcery.com> Date: Tue, 03 Jun 2014 05:35:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Pedro Alves , Subject: [PATCH OBV] Fix a regexp pattern in gdb.base/auto-connect-native-target.exp (Re: [PATCH 8/8] Allow making GDB not automatically connect to the native target.) References: <1395069784-7406-1-git-send-email-palves@redhat.com> <1395069784-7406-9-git-send-email-palves@redhat.com> In-Reply-To: <1395069784-7406-9-git-send-email-palves@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00060.txt.bz2 On 03/17/2014 11:23 PM, Pedro Alves wrote: > +set test "help target native" > +gdb_test_multiple $test $test { > + -re "Undefined target command.* $gdb_prompt $" { The space before "$gdb_prompt $" looks redundant and this patch is to remove it from the regexp pattern. > + set have_native 0 > + } > + -re "Native process.*$gdb_prompt $" { > + set have_native 1 > + } > +} -- Yao (齐尧) Subject: [PATCH] Fix a regexp pattern in gdb.base/auto-connect-native-target.exp When I test gdb head (for 7.8 release) on arm-none-eabi, I find the following failure, which is caused by the improper regexp pattern in the test. (gdb) help target native^M Undefined target command: "native". Try "help target".^M (gdb) FAIL: gdb.base/auto-connect-native-target.exp: help target native The space before "$gdb_prompt $" looks redundant, and this patch is to remove it from the regexp pattern. gdb/testsuite: 2014-06-03 Yao Qi * gdb.base/auto-connect-native-target.exp: Remove redundant space from the regexp pattern. --- gdb/testsuite/gdb.base/auto-connect-native-target.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/auto-connect-native-target.exp b/gdb/testsuite/gdb.base/auto-connect-native-target.exp index ac8c79f..79febe3 100644 --- a/gdb/testsuite/gdb.base/auto-connect-native-target.exp +++ b/gdb/testsuite/gdb.base/auto-connect-native-target.exp @@ -27,7 +27,7 @@ set have_native 0 set test "help target native" gdb_test_multiple $test $test { - -re "Undefined target command.* $gdb_prompt $" { + -re "Undefined target command.*$gdb_prompt $" { set have_native 0 } -re "Native process.*$gdb_prompt $" { -- 1.9.0