public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>,
	Joel Brobecker <brobecker@adacore.com>,
	<gdb-patches@sourceware.org>
Subject: Re: [ping]  [PATCH] Different outputs affected by locale
Date: Thu, 05 Jun 2014 09:58:00 -0000	[thread overview]
Message-ID: <53903EE5.8090107@codesourcery.com> (raw)
In-Reply-To: <53903119.6000204@redhat.com>

On 06/05/2014 04:58 PM, Pedro Alves wrote:
>> This is a not a mingw issue nor a remote host testing issue.  
> But that's a conflicting answer.  It's a remote host testing
> if this only triggers with remote host testing.
> 

OK, it is a remote host testing issue, since LC_CTYPE is set on build
only.

>> > If the
>> > LC_CTYPE isn't set properly on host, these tests will fail, even in the
>> > native testing.
> Sure, but it's supposed to be set, and then tests can assume so.
> If not set in some circumstance, then it's a bug in the test
> infrustruture, not the test.  For native testing, those are
> set by gdb.exp:gdb_init.
> 
>> > 
>>> >> ssh)?  Is LC_CTYPE really being propagated to the host?
>> > 
>> > No, setting env variables on host or target in dejagnu isn't trivial to
>> > me.
> They need to be passed down explicitly in the ssh command line:
> 
> $ ssh localhost "FOO=1 env | grep FOO"
> FOO=1
> 

Yes, it is simple to pass env variable through ssh, but isn't trivial to
pass env variable to host or target in dejagnu, because,

 - ssh is not the only connection dejagnu supports, how about telnet?
 - env variable should bind to board.  host and target can have
different env vars.

I saw Jie's patch to set env var on target
http://lists.gnu.org/archive/html/dejagnu/2008-07/msg00000.html
but we need do more than that, IMO.  That is the reason I am inclined to
fix the test case instead of the infrastructure (dejagnu).

>> > 
>>> >> Does testing GDB manually directly on a Windows console show the same
>>> >> issue?
>> > 
>> > Yes, here is the output I got on Windows 7 (running gdb.exe in Windows console).
>> > However, I didn't investigate why 'ó' is printed.
> But was that with LC_CTYPE set to C?

I don't know how check LC_CTYPE on Windows. :(

-- 
Yao (齐尧)

  reply	other threads:[~2014-06-05  9:58 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27 12:13 Yao Qi
2014-06-04  5:32 ` [ping] " Yao Qi
2014-06-04 12:47   ` Joel Brobecker
2014-06-04 13:21     ` Yao Qi
2014-06-04 13:52       ` Joel Brobecker
2014-06-04 20:15       ` Tom Tromey
2014-06-04 20:23         ` Pedro Alves
2014-06-05  3:31           ` Yao Qi
2014-06-05  8:58             ` Pedro Alves
2014-06-05  9:58               ` Yao Qi [this message]
2014-06-05 10:12                 ` Pedro Alves
2014-06-05 15:04                   ` Eli Zaretskii
2014-06-09  8:37                   ` Yao Qi
2014-06-09 10:11                     ` Pedro Alves
2014-06-11  2:22                       ` Yao Qi
2014-06-11 16:23                         ` Eli Zaretskii
2014-06-12  0:48                           ` Yao Qi
2014-06-12  2:47                             ` Eli Zaretskii
2014-06-12  7:04                               ` Yao Qi
2014-06-12 17:03                                 ` Eli Zaretskii
2014-06-17  1:03                                   ` Yao Qi
2014-06-12 11:36                         ` Pedro Alves
2014-06-12 14:39                           ` Yao Qi
2014-06-12 17:07                             ` Eli Zaretskii
2014-06-12 17:23                             ` Pedro Alves
2014-06-12 17:48                               ` Eli Zaretskii
2014-06-17  3:46                               ` Yao Qi
2014-06-17 10:03                                 ` Pedro Alves
2014-06-17 11:39                                   ` Yao Qi
2014-06-12 17:09                           ` Eli Zaretskii
2014-06-12 17:27                             ` Pedro Alves
2014-06-12 17:50                               ` Eli Zaretskii
2014-06-12 18:06                                 ` Pedro Alves
2014-06-12 18:35                                   ` Eli Zaretskii
2014-06-16 13:58                                     ` Pedro Alves
2014-06-16 15:40                                       ` Eli Zaretskii
2014-06-16 16:23                                         ` Pedro Alves
2014-06-05 10:27                 ` Pedro Alves
2014-06-05 14:47             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53903EE5.8090107@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).