From: Pedro Alves <palves@redhat.com>
To: Don Breazeal <donb@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix for follow-fork: followed child doesn't stop
Date: Thu, 05 Jun 2014 12:52:00 -0000 [thread overview]
Message-ID: <53906804.3070107@redhat.com> (raw)
In-Reply-To: <1401920383-10219-1-git-send-email-donb@codesourcery.com>
Hi Don,
On 06/04/2014 11:19 PM, Don Breazeal wrote:
> Using the test program gdb.base/foll-fork.c, with follow-fork-mode
> set to "child" and detach-on-fork set to "on", stepping past the
> fork call results in the child process running to completion, when
> it should just finish the single step.
>
> This is the result of how the single-step state is transferred from
> the parent to the child in infrun.c:follow_fork. For the parent, the
> single-step breakpoint is marked as "inserted" (bp->loc->inserted).
> The breakpoint is transferred to the child, where it clearly has never
> been inserted.
Was it removed from the parent already at this point? If so,
why is it still marked as inserted? If not, then it would sound
like your patch would make us miss removing it.
--
Pedro Alves
next prev parent reply other threads:[~2014-06-05 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 22:19 Don Breazeal
2014-06-05 12:52 ` Pedro Alves [this message]
2014-06-05 18:34 ` Breazeal, Don
2014-06-06 11:12 ` Pedro Alves
2014-06-06 11:42 ` Pedro Alves
2014-06-05 13:14 ` Luis Machado
2014-06-05 21:45 ` Breazeal, Don
2014-06-06 11:34 ` Pedro Alves
2014-06-13 1:07 ` Breazeal, Don
2014-06-16 13:19 ` Pedro Alves
2014-06-06 12:27 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53906804.3070107@redhat.com \
--to=palves@redhat.com \
--cc=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).