From: Luis Machado <lgustavo@codesourcery.com>
To: "Breazeal, Don" <donb@codesourcery.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix for follow-fork: followed child doesn't stop
Date: Fri, 06 Jun 2014 12:27:00 -0000 [thread overview]
Message-ID: <5391B3B1.3040701@codesourcery.com> (raw)
In-Reply-To: <5390E4D1.2050108@codesourcery.com>
Hi Don,
On 06/05/2014 10:44 PM, Breazeal, Don wrote:
> Hi Luis,
> Thanks for the review.
>
>>> + if (tp->control.step_resume_breakpoint != NULL)
>>> + tp->control.step_resume_breakpoint->loc->inserted = 0;
>>
>> Maybe add a little more context as to why this conditional is doing what
>> it is doing? I imagine someone scratching their head to figure this out.
>> Your description above makes good sense.
>
> I added a comment above the conditional. Let me know if it isn't what
> you had in mind.
>
That looks good to me. Thanks.
--snip--
> - if [runto_main] then { explicit_fork_parent_follow }
> + # The first two tests should be sufficient to test the defaults.
> + # There is no need to test using the defaults in other permutations
> + # (e.g. "default" "on", "parent" "default", etc.).
> + set cases [list [list "default" "default" "next 2"] \
> + [list "default" "default" "continue"] \
> + [list "parent" "on" "next 2"] \
> + [list "parent" "on" "continue"] \
> + [list "child" "on" "next 2"] \
> + [list "child" "on" "continue"] \
> + [list "parent" "off" "next 2"] \
> + [list "parent" "off" "continue"] \
> + [list "child" "off" "next 2"] \
> + [list "child" "off" "continue"]]
> + foreach args $cases {
> + test_follow_fork [lindex $args 0] [lindex $args 1] [lindex $args 2]
> + }
>
I had suggested what Pedro did, but my mail server wasn't too happy with
sending my mails out.
Luis
prev parent reply other threads:[~2014-06-06 12:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 22:19 Don Breazeal
2014-06-05 12:52 ` Pedro Alves
2014-06-05 18:34 ` Breazeal, Don
2014-06-06 11:12 ` Pedro Alves
2014-06-06 11:42 ` Pedro Alves
2014-06-05 13:14 ` Luis Machado
2014-06-05 21:45 ` Breazeal, Don
2014-06-06 11:34 ` Pedro Alves
2014-06-13 1:07 ` Breazeal, Don
2014-06-16 13:19 ` Pedro Alves
2014-06-06 12:27 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5391B3B1.3040701@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).