Re: [Patch, microblaze]: Add slr and shr regs

[Michael Eager <eager@eagerm.com>]

On 06/09/14 10:26, Ajit Kumar Agarwal wrote:
>
> Sorry for the late response as I was on Vacation. Please find my response inlined below.

It's difficult to figure out which are your responses and which
is text quoted from previous email.

AJA:
> SLR/SHR was added in MicroBlaze v8.10.a, EDK 13.1.  XMD's gdbserver stub releasesed before this design throws an error mentioning gdb is not supported  for the version below v8.10.a, EDK 13.1.

I don't know what this means.  XMD released with EDK 9.1i doesn't generate any
such error message and works with mb-gdb built from FSF sources.

There are several ways to make gdb to adapt to different target architectures.
Pedro described the preferred solution, but there are others.

MJE:
>>> I do not have any way to test microblaze-linux.  Make sure that your patch works with both -target=microblaze-linux and -target=microblaze-xilinx-gnu, and with both EDK 9.1i and >>14.2i, at a minimum.  Please provide documentation which show that this patch works using gdbserver on a Linux target, as well as using XMD.

AJA:
> Same as the Explanation above. The native Linux support patch is not yet  submitted and we will submitting the patches after this patch.  XMD testing is done and it works fine.

This isn't responsive to my request.

The only way that your patch makes sense is if you build
gdbserver for a microblaze-linux target.  If this is not
what you are doing, you need to explain (as previously
requested) how you are building and testing the patch.

MJE:
> When you resubmit the patch, please make sure that you check for whitespace errors.  Make sure that you address all of the questions and comments made here and by other reviewers.

Please respond to all comments.

-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077