From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6029 invoked by alias); 9 Jun 2014 18:28:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6008 invoked by uid 89); 9 Jun 2014 18:28:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: homiemail-a45.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a45.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jun 2014 18:28:56 +0000 Received: from homiemail-a45.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a45.g.dreamhost.com (Postfix) with ESMTP id D67E84809C; Mon, 9 Jun 2014 11:28:54 -0700 (PDT) Received: from redwood.eagercon.com (c-24-7-16-38.hsd1.ca.comcast.net [24.7.16.38]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a45.g.dreamhost.com (Postfix) with ESMTPSA id A389C48093; Mon, 9 Jun 2014 11:28:54 -0700 (PDT) Message-ID: <5395FCE6.80702@eagerm.com> Date: Mon, 09 Jun 2014 18:28:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ajit Kumar Agarwal , "gdb-patches@sourceware.org" CC: Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch, microblaze]: Add slr and shr regs References: <537EFA08.1060309@eagercon.com> <537FCEDA.9030504@eagercon.com> <2e5c185d-329c-46cf-930c-8cc2288891aa@BN1BFFO11FD019.protection.gbl> <538431FB.2070904@eagercon.com> <865132b2-a593-4147-a7c6-cee25c1ed0fd@BN1AFFO11FD052.protection.gbl> <53909299.9010105@eagerm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00400.txt.bz2 On 06/09/14 10:26, Ajit Kumar Agarwal wrote: > > Sorry for the late response as I was on Vacation. Please find my response inlined below. It's difficult to figure out which are your responses and which is text quoted from previous email. AJA: > SLR/SHR was added in MicroBlaze v8.10.a, EDK 13.1. XMD's gdbserver stub releasesed before this design throws an error mentioning gdb is not supported for the version below v8.10.a, EDK 13.1. I don't know what this means. XMD released with EDK 9.1i doesn't generate any such error message and works with mb-gdb built from FSF sources. There are several ways to make gdb to adapt to different target architectures. Pedro described the preferred solution, but there are others. MJE: >>> I do not have any way to test microblaze-linux. Make sure that your patch works with both -target=microblaze-linux and -target=microblaze-xilinx-gnu, and with both EDK 9.1i and >>14.2i, at a minimum. Please provide documentation which show that this patch works using gdbserver on a Linux target, as well as using XMD. AJA: > Same as the Explanation above. The native Linux support patch is not yet submitted and we will submitting the patches after this patch. XMD testing is done and it works fine. This isn't responsive to my request. The only way that your patch makes sense is if you build gdbserver for a microblaze-linux target. If this is not what you are doing, you need to explain (as previously requested) how you are building and testing the patch. MJE: > When you resubmit the patch, please make sure that you check for whitespace errors. Make sure that you address all of the questions and comments made here and by other reviewers. Please respond to all comments. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077