From: Michael Eager <eager@eagerm.com>
To: Ajit Kumar Agarwal <ajit.kumar.agarwal@xilinx.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Vinod Kathail <vinodk@xilinx.com>,
Vidhumouli Hunsigida <vidhum@xilinx.com>,
Nagaraju Mekala <nmekala@xilinx.com>
Subject: Re: [Patch, microblaze]: Add slr and shr regs
Date: Tue, 10 Jun 2014 15:27:00 -0000 [thread overview]
Message-ID: <539723D0.7030505@eagerm.com> (raw)
In-Reply-To: <3a07b07b-b3e1-4030-94f8-da6ee73b9267@BL2FFO11FD025.protection.gbl>
On 06/10/14 07:49, Ajit Kumar Agarwal wrote:
>
> -----Original Message-----
> From: Michael Eager [mailto:eager@eagerm.com]
> Sent: Tuesday, June 10, 2014 7:42 PM
> To: Ajit Kumar Agarwal; gdb-patches@sourceware.org
> Cc: Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
> Subject: Re: [Patch, microblaze]: Add slr and shr regs
>
> On 06/10/14 06:50, Ajit Kumar Agarwal wrote:
>>
>>>> XMD is not running gdbserver built with these sources, is it?
>>
>> Yes XMD is not running gdbserver built with these sources.
>>
>>>> Your patch modified files under gdb/gdbserver. When you build binutils/gdb with -target=microblaze-xilinx-elf, these files are not built.
>>
>> The patch related to building gdbserver with the latest FSF Sources will be the next patch which I am going to submit for review.
>
>>> Changes related to building gdbserver should be submitted together. It sounds like this patch is dependent on some future patch.
>
> Could you please explain why you think building gdbserver should be submitted together?. This patch is related to the problem of Remote G Packet error which is mainly targeted for baremetal.
> Solving the mismatching error between packets returning from XMD Stub and GDB.
Your patch contains changes to gdbserver. As far as you have
indicated, you haven't built or tested gdbserver from these sources.
> This is plainly independent of the patch that deals with gdbserver patch which mainly deals with native linux debugging support which is quite independent of this patch.
I have no idea what your future patch will contain.
I don't particularly care whether you submit the
gdbserver changes in this patch together with
this unknown future patch, or whether you submit them
as multiple patches. It appears that these changes are
inappropriate for a patch which is unrelated.
>>> Please submit a revised patch which addresses one problem:
>>> support for the added registers in MicroBlaze v8.10a. As mentioned previously, gdb built with this patch should continue to support the same versions of MicroBlaze that are currently supported.
>
> Support for SHR/SHL registers with baremetal support is quite different from the patch with building gdbserver as XMD doesn’t use the gdbserver stub from the FSF sources. It has its own gdbserver And we don’t have plans to replace gdb Server in XMD with gdbserver from FSF Sources. The building of gdbServer from FSF is mainly related to Linux native debugging and use for Linux image Support of MIcroblaze which is quite independent of the patch submitted for baremetal.
Yes, support for baremetal is quite different from Linux patches.
This patch is only for baremetal support and should not contain
changes to gdbserver.
> I don’t see any relations between the two and why the patches should be submitted together.
I'm asking you to have one patch address one change.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2014-06-10 15:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 6:54 Ajit Kumar Agarwal
2014-05-23 7:34 ` Michael Eager
2014-05-23 9:47 ` Ajit Kumar Agarwal
2014-05-23 22:42 ` Michael Eager
2014-05-26 10:04 ` Ajit Kumar Agarwal
2014-05-27 6:34 ` Michael Eager
2014-05-27 7:46 ` Ajit Kumar Agarwal
2014-05-27 8:53 ` Pedro Alves
2014-06-09 17:26 ` Ajit Kumar Agarwal
2014-06-09 17:57 ` Pedro Alves
2014-06-09 19:35 ` Ajit Kumar Agarwal
2014-05-29 7:20 ` Michael Eager
2014-06-05 15:54 ` Michael Eager
2014-06-09 17:26 ` Ajit Kumar Agarwal
2014-06-09 18:28 ` Michael Eager
2014-06-09 19:31 ` Ajit Kumar Agarwal
2014-06-09 20:06 ` Michael Eager
2014-06-10 13:51 ` Ajit Kumar Agarwal
2014-06-10 14:12 ` Michael Eager
2014-06-10 14:49 ` Ajit Kumar Agarwal
2014-06-10 15:27 ` Michael Eager [this message]
2014-06-12 8:34 ` Ajit Kumar Agarwal
2014-05-23 8:32 ` Yao Qi
2014-05-23 20:33 ` Ajit Kumar Agarwal
2014-05-23 8:44 ` Pedro Alves
2014-05-23 20:36 ` Ajit Kumar Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539723D0.7030505@eagerm.com \
--to=eager@eagerm.com \
--cc=ajit.kumar.agarwal@xilinx.com \
--cc=gdb-patches@sourceware.org \
--cc=nmekala@xilinx.com \
--cc=vidhum@xilinx.com \
--cc=vinodk@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).