From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3668 invoked by alias); 11 Jun 2014 11:24:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3654 invoked by uid 89); 11 Jun 2014 11:24:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Jun 2014 11:24:57 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WugeD-0003JW-Oy from Luis_Gustavo@mentor.com ; Wed, 11 Jun 2014 04:24:53 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 11 Jun 2014 04:24:53 -0700 Received: from [172.30.3.151] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Wed, 11 Jun 2014 04:24:52 -0700 Message-ID: <53983C82.4040208@codesourcery.com> Date: Wed, 11 Jun 2014 11:24:00 -0000 From: Luis Machado Reply-To: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Terry Guo , 'Will Newton' CC: Subject: Re: [Patch]Clean up the XML files for ARM References: <000b01cf8540$dafa6d80$90ef4880$@arm.com> <001701cf8555$40925540$c1b6ffc0$@arm.com> In-Reply-To: <001701cf8555$40925540$c1b6ffc0$@arm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00441.txt.bz2 On 06/11/2014 10:12 AM, Terry Guo wrote: > > >> -----Original Message----- >> From: Will Newton [mailto:will.newton@linaro.org] >> Sent: Wednesday, June 11, 2014 4:16 PM >> To: Terry Guo >> Cc: gdb-patches@sourceware.org >> Subject: Re: [Patch]Clean up the XML files for ARM >> >> On 11 June 2014 07:46, Terry Guo wrote: >>> Hi There, >>> >>> Under folder gdb/features we are having more and more ARM related XML >> files. >>> This patch intends to move those ARM XML files into a new folder named >> arm. >>> All the references to those files are now prefixed with folder name arm. >>> Please be noted that this doesn't include AArch64 XML files so far. Is >>> it ok to GDB trunk? >>> >>> BR, >>> Terry >>> >>> 2014-06-11 Terry Guo >>> >>> * features/arm-core.xml: Move to ... >>> * features/arm/arm-core.xml: ... here. >>> * features/arm-fpa.xml: Move to ... >>> * features/arm/arm-fpa.xml: ... here. >>> * features/arm-m-profile.xml: Move to ... >>> * features/arm/arm-m-profile.xml: ... here. >>> * features/arm-vfpv2.xml: Move to ... >>> * features/arm/arm-vfpv2.xml: ... here. >>> * features/arm-vfpv3.xml: Move to ... >>> * features/arm/arm-vfpv3.xml: ... here. >>> * features/arm-with-iwmmxt.xml: Move to ... >>> * features/arm/arm-with-iwmmxt.xml: ... here. >>> * features/arm-with-iwmmxt.c: Move to ... >>> * features/arm/arm-with-iwmmxt.c: ... here. >>> * features/arm-with-m.xml: Move to ... >>> * features/arm/arm-with-m.xml: ... here. >>> * features/arm-with-m.c: Move to ... >>> * features/arm/arm-with-m.c: ... here. >>> * features/arm-with-m-fpa-layout.xml: Move to ... >>> * features/arm/arm-with-m-fpa-layout.xml: ... here. >>> * features/arm-with-m-fpa-layout.c: Move to ... >>> * features/arm/arm-with-m-fpa-layout.c: ... here. >>> * features/arm-with-m-vfp-d16.xml: Move to ... >>> * features/arm/arm-with-m-vfp-d16.xml: ... here. >>> * features/arm-with-m-vfp-d16.c: Move to ... >>> * features/arm/arm-with-m-vfp-d16.c: ... here. >>> * features/arm-with-neon.xml: Move to ... >>> * features/arm/arm-with-neon.xml: ... here. >>> * features/arm-with-neon.c: Move to ... >>> * features/arm/arm-with-neon.c: ... here. >>> * features/arm-with-vfpv2.xml: Move to ... >>> * features/arm/arm-with-vfpv2.xml: ... here. >>> * features/arm-with-vfpv2.c: Move to ... >>> * features/arm/arm-with-vfpv2.c: ... here. >>> * features/arm-with-vfpv3.xml: Move to ... >>> * features/arm/arm-with-vfpv3.xml: ... here. >>> * features/arm-with-vfpv3.c: Move to ... >>> * features/arm/arm-with-vfpv3.c: ... here. >>> * features/Makefile: Use new paths to refer ARM files. >>> * arm-tdep.c: Use new paths to include files. >> >> It seems like we have duplicate "arm" in some of the names now, it might be >> a good cleanup to rename, e.g.: >> >> features/arm/arm-vfpv3.xml -> features/arm/vfpv3.xml >> > > Thanks for comments. But files in folder i386 and rs6000 are same as mine. Maybe there are reasons to do so. > > For example: > > i386/ > i386/i386-mmx.c > i386/32bit-avx512.xml > i386/x32-avx512.xml > i386/x32-avx512-linux.c > i386/32bit-sse.xml > i386/32bit-mpx.xml > i386/i386-avx-linux.xml > i386/i386-mpx.c > i386/i386-mpx-linux.xml > i386/x32-core.xml > i386/64bit-core.xml > i386/i386.xml > > ./rs6000/powerpc-isa205-altivec64l.xml > ./rs6000/powerpc-e500l.c > ./rs6000/powerpc-altivec64l.c > ./rs6000/powerpc-603.xml > ./rs6000/powerpc-602.xml > ./rs6000/power64-core.xml > ./rs6000/powerpc-64.c > ./rs6000/powerpc-altivec64.c > ./rs6000/powerpc-505.xml > > BR, > Terry I think one of the reasons for having duplication there is that nobody commented about it, like Will. I'd go for the cleaner names without the duplication. The duplication certainly doesn't add anything to it. Luis Luis