From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8185 invoked by alias); 12 Jun 2014 13:04:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8167 invoked by uid 89); 12 Jun 2014 13:04:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jun 2014 13:04:24 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5CD4Moo009230 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 12 Jun 2014 09:04:23 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5CD4Ll3024080; Thu, 12 Jun 2014 09:04:22 -0400 Message-ID: <5399A554.6060708@redhat.com> Date: Thu, 12 Jun 2014 13:04:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] more constification References: <1402512797-6082-1-git-send-email-tromey@redhat.com> In-Reply-To: <1402512797-6082-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00500.txt.bz2 On 06/11/2014 07:53 PM, Tom Tromey wrote: > This series constifies a few more things in gdb. > > A few of the patches are very basic and #4 is downright trivial. > > Patch #6 casts away const in a couple spots. There's a justification > in the patch; but I also wanted to add that the casts only affect > mdebugread.c, which can't really be said to be actively maintained in > any case. > > Some of these patches are part of a larger work to constify the > argument pass to gdb commands. This longer series isn't finished yet; > but it simplifies to the work to put patches in bottom-up and mildly > improves gdb in the process. Looked fine to me. A couple nits I noticed: - The subject of patch #3 sounds like something you'd have in a local branch. Should that patch be merged with some other in the series? Does GDB build at each step of the series? - A typo in the log of patch #6: "SO". -- Pedro Alves