public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Initial pass at D language expression parser support.
Date: Tue, 17 Jun 2014 10:22:00 -0000	[thread overview]
Message-ID: <53A016E3.8070109@redhat.com> (raw)
In-Reply-To: <CABOHX+cZzCNQAwRVnMhxBRH6-cAKx95+OdhfJ50ZtmZA+FVJJw@mail.gmail.com>

On 06/05/2014 12:43 AM, Iain Buclaw wrote:

>     Initial pass at D language expression parser support.
> 
>     2014-06-05  Iain Buclaw  <ibuclaw@gdcproject.org>
> 
>         * Makefile.in (SFILES): Add d-exp.y.
>         (YYFILES): Add d-exp.c.
>         (YYOBJ): Add d-exp.o.
>         (local-maintainer-clean): Delete d-exp.c.
>         * d-exp.y: New file.
>         * d-lang.h (d_parse): New declaration.
>         (d_error): New declaration.
>         * d-lang.c (d_op_print_tab): Add entry for BINOP_CONCAT and BINOP_EXP.
>         Set BINOP_EQUAL and BINOP_NOTEQUAL to same precedence as other
>         PREC_ORDER operators.
>         (d_language_defn): Use d_parse, d_error instead of c_parse, c_error.
> 
>     2014-06-05  Iain Buclaw  <ibuclaw@gdcproject.org>
> 
>         * gdb.dlang/expression.exp: New file.

As this is pretty much self contained in the D support code, and
doesn't touch core GDB, I think it should just be pushed in.

FWIW, I quickly skimmed it and nothing raised my eyebrows.

Thus, OK.

Thanks,
-- 
Pedro Alves

  parent reply	other threads:[~2014-06-17 10:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 23:43 Iain Buclaw
2014-06-16 16:37 ` Iain Buclaw
2014-06-17 10:22 ` Pedro Alves [this message]
2014-06-18 21:28   ` Iain Buclaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A016E3.8070109@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ibuclaw@gdcproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).