From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14344 invoked by alias); 17 Jun 2014 10:22:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14252 invoked by uid 89); 17 Jun 2014 10:22:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jun 2014 10:22:34 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5HAMURO001505 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Jun 2014 06:22:30 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5HAMSmG015047; Tue, 17 Jun 2014 06:22:29 -0400 Message-ID: <53A016E3.8070109@redhat.com> Date: Tue, 17 Jun 2014 10:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Iain Buclaw , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Initial pass at D language expression parser support. References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00578.txt.bz2 On 06/05/2014 12:43 AM, Iain Buclaw wrote: > Initial pass at D language expression parser support. > > 2014-06-05 Iain Buclaw > > * Makefile.in (SFILES): Add d-exp.y. > (YYFILES): Add d-exp.c. > (YYOBJ): Add d-exp.o. > (local-maintainer-clean): Delete d-exp.c. > * d-exp.y: New file. > * d-lang.h (d_parse): New declaration. > (d_error): New declaration. > * d-lang.c (d_op_print_tab): Add entry for BINOP_CONCAT and BINOP_EXP. > Set BINOP_EQUAL and BINOP_NOTEQUAL to same precedence as other > PREC_ORDER operators. > (d_language_defn): Use d_parse, d_error instead of c_parse, c_error. > > 2014-06-05 Iain Buclaw > > * gdb.dlang/expression.exp: New file. As this is pretty much self contained in the D support code, and doesn't touch core GDB, I think it should just be pushed in. FWIW, I quickly skimmed it and nothing raised my eyebrows. Thus, OK. Thanks, -- Pedro Alves