From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28456 invoked by alias); 17 Jun 2014 16:10:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28431 invoked by uid 89); 17 Jun 2014 16:10:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jun 2014 16:10:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5HG9wVg016130 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 17 Jun 2014 12:09:58 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5HG9uoj013598; Tue, 17 Jun 2014 12:09:57 -0400 Message-ID: <53A06854.2080608@redhat.com> Date: Tue, 17 Jun 2014 16:10:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 10/15] Abstract i386_dr_low access References: <1403014378-4349-1-git-send-email-gbenson@redhat.com> <1403014378-4349-11-git-send-email-gbenson@redhat.com> In-Reply-To: <1403014378-4349-11-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00612.txt.bz2 On 06/17/2014 03:12 PM, Gary Benson wrote: > This commit adds macros to abstract access to the i386_dr_low > function vector used by i386-nat.c. The macros are named so > as to match the names of the functions that do the same work > in gdbserver. > > gdb/ > 2014-06-17 Gary Benson > > * i386-nat.c (i386_dr_low_can_set_addr): New macro. > (i386_dr_low_can_set_control): Likewise. > (i386_dr_low_set_addr): Likewise. > (i386_dr_low_set_control): Likewise. > (i386_dr_low_get_addr): Likewise. > (i386_dr_low_get_status): Likewise. > (i386_dr_low_get_control): Likewise. > (i386_insert_aligned_watchpoint): Use new macros. > (i386_update_inferior_debug_regs): Likewise. > (i386_stopped_data_address): Likewise. > > gdb/gdbserver/ > 2014-06-17 Gary Benson > > * i386-low.c (i386_dr_low_can_set_addr): New macro. > (i386_dr_low_can_set_control): Likewise. > (i386_insert_aligned_watchpoint): New check. OK. Thanks, -- Pedro Alves