From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19817 invoked by alias); 17 Jun 2014 17:11:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19806 invoked by uid 89); 17 Jun 2014 17:11:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jun 2014 17:11:56 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5HHBsMf023435 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 17 Jun 2014 13:11:54 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5HHBrWZ018029; Tue, 17 Jun 2014 13:11:54 -0400 Message-ID: <53A076D9.7020104@redhat.com> Date: Tue, 17 Jun 2014 17:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Gary Benson CC: gdb-patches@sourceware.org Subject: Re: [PATCH 04/15] Comment changes References: <1403014378-4349-1-git-send-email-gbenson@redhat.com> <1403014378-4349-5-git-send-email-gbenson@redhat.com> <53A062B1.5060005@redhat.com> <20140617160958.GA6680@blade.nx> In-Reply-To: <20140617160958.GA6680@blade.nx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00628.txt.bz2 On 06/17/2014 05:09 PM, Gary Benson wrote: > Pedro Alves wrote: >> On 06/17/2014 03:12 PM, Gary Benson wrote: >>> This commit fixes various whitespace differences between >> >> s/whitespace/comment/ > > Oops :) > >>> /* In non-stop/async, threads can be running while we change the >>> - STATE (and friends). Say, we set a watchpoint, and let threads >> >>> + global dr_mirror (and friends). Say, we set a watchpoint, and >>> + let threads resume. Now, say you delete the watchpoint, or >> >> Wrong direction, here, I'm afraid. There's no _global_ dr_mirror >> anymore. There used to be one, before multi-process. > > Is s/global dr_mirror/dr_mirror/ ok, or something else? Hmm, you know what, neither version is strictly correct. "the STATE (and friends)" was clearly a blind search&replace. So, to makes things easy, and avoid a potentially make-work rebase, just leave it as you had it, and we can clean it up afterwards. -- Pedro Alves