From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8248 invoked by alias); 18 Jun 2014 14:18:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8236 invoked by uid 89); 18 Jun 2014 14:18:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Jun 2014 14:18:29 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5IEIQKo031741 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Jun 2014 10:18:26 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5IEIOia015612; Wed, 18 Jun 2014 10:18:25 -0400 Message-ID: <53A19FB0.5070800@redhat.com> Date: Wed, 18 Jun 2014 14:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Gary Benson CC: Siva Chandra , gdb-patches Subject: Re: [PATCH 11/15] Rename functions and make nonstatic as necessary References: <1403014378-4349-1-git-send-email-gbenson@redhat.com> <1403014378-4349-12-git-send-email-gbenson@redhat.com> <20140618132832.GA6225@blade.nx> <53A19A53.6030107@redhat.com> <20140618140952.GA28449@blade.nx> In-Reply-To: <20140618140952.GA28449@blade.nx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00660.txt.bz2 On 06/18/2014 03:09 PM, Gary Benson wrote: > Pedro Alves wrote: >> On 06/18/2014 02:28 PM, Gary Benson wrote: >>> Siva Chandra wrote: >>>> On Tue, Jun 17, 2014 at 7:12 AM, Gary Benson wrote: >>>>> This commit renames the functions that are to be shared. >>>>> Functions to be shared that were static are made nonstatic. >>>> > >>>> I thinking making the functions nonstatic in this part was >>>> not correct. The build currently fails when built with >>>> "-Werror=missing-prototypes" as 14/15 has not yet been >>>> committed. >>> >>> My apologies Siva. >>> >>> Pedro, should I commit the remaining piece now, and work on the >>> i386_insert_hw_breakpoint as a separate patch? >> >> As you've committed the header patch already, I think the issue >> is actually already fixed? > > Ah, ok, I misunderstood. I can stop rushing! > > I actually wish I hadn't committed the header patch now, the > i386_{insert,remove}_hw_breakpoint refactoring you spotted > means those functions didn't need exposing at all. > > I'm working on a patch to revert part of that change: remove the > prototypes, make them static again, *and* rename the now static > functions them back to their original names. The last point isn't > strictly necessary, but I don't like that the refactoring would > have renamed some functions it didn't need to. I want to put the > old names back so that people familiar with that code don't see > more disruption than strictly necessary. > > I was going to mail it alone (I thought Siva was stuck) but since > he's not I'll mail it as part of a three-patch series to complete > the refactoring. Sounds excellent. Thanks, -- Pedro Alves