From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22220 invoked by alias); 19 Jun 2014 10:45:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22206 invoked by uid 89); 19 Jun 2014 10:45:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 19 Jun 2014 10:45:20 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5JAjJVO028487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Jun 2014 06:45:19 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5JAjHZm004552; Thu, 19 Jun 2014 06:45:18 -0400 Message-ID: <53A2BF3C.7040505@redhat.com> Date: Thu, 19 Jun 2014 10:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Mark Kettenis CC: gbenson@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH 0/4 v2] Refactor shared code in i386-{nat,low}.[ch] References: <1403104976-2492-1-git-send-email-gbenson@redhat.com> <201406181606.s5IG6Mud000672@glazunov.sibelius.xs4all.nl> <53A1B9E8.5010504@redhat.com> <201406181748.s5IHmM3H005254@glazunov.sibelius.xs4all.nl> <53A1D408.5020001@redhat.com> In-Reply-To: <53A1D408.5020001@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00699.txt.bz2 On 06/18/2014 07:01 PM, Pedro Alves wrote: > (The "common" moniker was a not-to-great idea that we're moving away from. > "common" suggests that what we put there is necessarily "common" between more > than one thing, instead of suggesting what the code is supposed to do. > If some change in GDB or GDBserver makes it so that some code in common/ is > no longer used in one of GDB or GDBserver's, then what to do? > Thus, "nat/" -- it holds native target specific code. From GDBserver's > perspective, it's target backends are native targets. This was all > previously discussed before, months ago, but we haven't updated the wiki > yet. We should.) I've now updated the wiki: https://sourceware.org/gdb/wiki/Common#Where_to_put_shared_code.3F -- Pedro Alves