From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] x86 Linux watchpoints: Couldn't write debug register: Invalid, argument.
Date: Fri, 20 Jun 2014 17:52:00 -0000 [thread overview]
Message-ID: <53A474C1.9030305@redhat.com> (raw)
In-Reply-To: <878uor8ofr.fsf@fleche.redhat.com>
On 06/20/2014 06:45 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> I _still_ had to touch 3 different places with the same code... I'm
> Pedro> very much looking forward to having all that merged.
>
> Yeah. In the meantime perhaps copying the comments into all 3 copies
> would make it simpler for the eventual merge. I noticed that the
> comments are not in linux-x86-low.c or i386-linux-nat.c.
That's following the existing practice, actually.
amd64-linux-nat.c has:
/* On Linux kernel before 2.6.33 commit
72f674d203cd230426437cdcf7dd6f681dad8b0d
if you enable a breakpoint by the DR_CONTROL bits you need to have
already written the corresponding DR_FIRSTADDR...DR_LASTADDR registers.
Ensure DR_CONTROL gets written as the very last register here. */
while i386-linux-nat.c just has:
/* See amd64_linux_prepare_to_resume for Linux kernel note on
i386_linux_dr_set calls ordering. */
I don't think trying to keep this in sync now would help, and at least
this way we have one place that is master. Gary's recent series showed
how when these comments are duplicated they end up diverging. :-/
--
Pedro Alves
next prev parent reply other threads:[~2014-06-20 17:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 1:10 [PATCH v3 0/5] Fix lost events, and handle multiple step-overs Pedro Alves
2014-03-07 1:10 ` [PATCH v3 3/5] Fix for even more missed events; eliminate thread-hop code Pedro Alves
2014-03-07 1:10 ` [PATCH v3 5/5] Make signal-while-stepping-over-bp-other-thread.exp run against remote targets too Pedro Alves
2014-03-07 1:10 ` [PATCH v3 2/5] PR breakpoints/7143 - Watchpoint does not trigger when first set Pedro Alves
2014-03-16 3:41 ` Doug Evans
2014-03-17 17:11 ` Pedro Alves
2014-03-19 16:52 ` Doug Evans
2014-03-20 13:58 ` Pedro Alves
2014-03-20 13:57 ` Pedro Alves
2014-06-17 19:18 ` Regression for watchpoint-fork.exp [Re: [PATCH v3 2/5] PR breakpoints/7143 - Watchpoint does not trigger when first set] Jan Kratochvil
2014-06-18 10:43 ` Pedro Alves
2014-06-19 13:43 ` Jan Kratochvil
2014-06-19 15:02 ` Pedro Alves
2014-06-19 16:56 ` Pedro Alves
2014-06-19 17:00 ` Jan Kratochvil
2014-06-20 16:53 ` [PATCH] x86 Linux watchpoints: Couldn't write debug register: Invalid, argument Pedro Alves
2014-06-20 17:45 ` Tom Tromey
2014-06-20 17:52 ` Pedro Alves [this message]
2014-06-20 17:53 ` Tom Tromey
2014-06-22 18:31 ` Jan Kratochvil
2014-06-23 17:41 ` Pedro Alves
2014-06-23 17:44 ` Pedro Alves
2014-03-07 1:10 ` [PATCH v3 1/5] Fix missing breakpoint/watchpoint hits, eliminate deferred_step_ptid Pedro Alves
2014-03-07 1:10 ` [PATCH v3 4/5] Handle multiple step-overs Pedro Alves
2014-03-20 13:59 ` [PUSHED] Re: [PATCH v3 0/5] Fix lost events, and handle " Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A474C1.9030305@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).