From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30311 invoked by alias); 23 Jun 2014 12:41:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30297 invoked by uid 89); 23 Jun 2014 12:41:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Jun 2014 12:41:06 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5NCf2vn007425 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Jun 2014 08:41:02 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5NCf0jB029433; Mon, 23 Jun 2014 08:41:01 -0400 Message-ID: <53A8205C.50201@redhat.com> Date: Mon, 23 Jun 2014 12:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Terry Guo CC: gdb-patches@sourceware.org Subject: Re: [Patch]Clean up the XML files for ARM References: <000b01cf8540$dafa6d80$90ef4880$@arm.com> <001701cf8555$40925540$c1b6ffc0$@arm.com> <53983C82.4040208@codesourcery.com> <001801cf85ef$f9decd40$ed9c67c0$@arm.com> <000001cf8908$49f991f0$ddecb5d0$@arm.com> <001501cf8c34$7336e840$59a4b8c0$@arm.com> <53A40465.70508@redhat.com> <001c01cf8c71$6e7295b0$4b57c110$@arm.com> <53A41949.70005@redhat.com> <002601cf8dd3$6ee6f780$4cb4e680$@arm.com> In-Reply-To: <002601cf8dd3$6ee6f780$4cb4e680$@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00806.txt.bz2 On 06/22/2014 05:35 AM, Terry Guo wrote: > rename from gdb/features/arm-with-m-vfp-d16.c > rename to gdb/features/arm/with-m-vfp-d16.c > index a0da583..5f47e3d 100644 > --- a/gdb/features/arm-with-m-vfp-d16.c > +++ b/gdb/features/arm/with-m-vfp-d16.c > @@ -1,13 +1,13 @@ > /* THIS FILE IS GENERATED. -*- buffer-read-only: t -*- vi:set ro: > - Original: arm-with-m-vfp-d16.xml */ > + Original: with-m-vfp-d16.xml */ Thank you. However, I've just now realized a design problem with losing the prefixes all over... :-( > -struct target_desc *tdesc_arm_with_m_vfp_d16; > +struct target_desc *tdesc_with_m_vfp_d16; > static void > -initialize_tdesc_arm_with_m_vfp_d16 (void) > +initialize_tdesc_with_m_vfp_d16 (void) > { Losing the prefix in the generated code is problematic for multi-arch (--enable-target=all) builds, because this way we're open for conflict between archs. E.g., say we have arch1/linux.xml arch1/linux.c arch2/linux.xml arch2/linux.c Then we end up with multiple conflicting definitions of "struct target_desc *tdesc_linux;" I think we should fix this by making the directory name be a prefix in the generated code. That is, in the ARM case, these hunks would disappear from your patch: > -struct target_desc *tdesc_arm_with_m_vfp_d16; > +struct target_desc *tdesc_with_m_vfp_d16; > static void > -initialize_tdesc_arm_with_m_vfp_d16 (void) > +initialize_tdesc_with_m_vfp_d16 (void) > { Would you like to work on this? -- Pedro Alves