Re: [Patch, microblaze]: Fix for remote G Packet message too long error for baremetal.

[Pedro Alves <palves@redhat.com>]

On 06/24/2014 11:28 AM, Ajit Kumar Agarwal wrote:

>> +  if (tdesc == NULL)
>> +    tdesc = tdesc_microblaze_with_stack_protect;
> 
> Shouldn't the default be to _not_ assume stack protect ?
> 
> The default is choosen to assume stack protect to make compatible with the handling of stack protect registers in XMD Debugger.

But you've already added the G packet size guess for that.

>> -
>> +  if (tdesc_data != NULL)
>> +    {
>> +      tdesc_use_registers (gdbarch, tdesc, tdesc_data);
>> +      set_gdbarch_register_type (gdbarch, microblaze_register_type);
> 
>>> Hmm, why is this set_gdbarch_register_type call necessary?
> 
> /* Override tdesc_register_type to adjust the types of VFP
>          registers for NEON.  */
> This is done for arm target  to set the different type for VFP registers for Neon with Boolean flags is set before this call for VFP registers. In the microblaze target it's not required for special case of stack protect as the microblaze_register_type always return builtin_int for these stack protect registers.
> 
> 

Right.

>>> As I mentioned before, please don't forget to document the new target features in the manual.
> 
> Would you mind in explaining which manual need to be changed for the new target.

The GDB manual, gdb/doc/gdb.texinfo, describes all the standard XML target
features.  See the "Standard Target Features" node, and add a new subsection
for MicroBlaze.

-- 
Pedro Alves