From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26798 invoked by alias); 10 Jul 2014 09:26:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26755 invoked by uid 89); 10 Jul 2014 09:26:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Jul 2014 09:26:49 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1X5Acn-0004bI-Ml from Yao_Qi@mentor.com ; Thu, 10 Jul 2014 02:26:45 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 10 Jul 2014 02:26:45 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Thu, 10 Jul 2014 02:25:57 -0700 Message-ID: <53BE5B84.6080301@codesourcery.com> Date: Thu, 10 Jul 2014 09:26:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH 5/9] Canceling pagination caused by execution command from command line aborts readline/gdb References: <1404400736-17307-1-git-send-email-palves@redhat.com> <1404400736-17307-6-git-send-email-palves@redhat.com> <53B6454E.8050709@codesourcery.com> <53BD71BB.5070302@redhat.com> In-Reply-To: <53BD71BB.5070302@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00203.txt.bz2 On 07/10/2014 12:45 AM, Pedro Alves wrote: > Looks like we already have a ton of tests using sleep/usleep, > so such a fix would best be done across the board. Perhaps > even by adding a sleep.h header to testsuite/lib/ or some such ? > Or if not needed with newer toolchains, just ignore it. :-) Yes, sleep has been widely used in the testsuite, but some of these tests are not really compiled nor executed on mingw. I'll take a look if it makes trouble, but I am fine to ignore it at current stage. > >>> >> +proc probe_can_run_cmdline {} { >>> >> + global srcfile binfile >>> >> + global saved_gdbflags GDBFLAGS >>> >> + global gdb_prompt >>> >> + >>> >> + set GDBFLAGS $saved_gdbflags >>> >> + append GDBFLAGS " -ex \"set height 0\"" >>> >> + append GDBFLAGS " -ex \"start\"" >>> >> + append GDBFLAGS " --args \"$binfile\"" >> > >> > This doesn't work on remote host, as we haven't copy binfile from build >> > to host yet. We can do this after build_executable, and pass $file_arg >> > to each proc instead of using $binfile in each proc. > Thanks. See the new version below. It looks good to me. I don't have other comments. -- Yao (齐尧)