From: Pedro Alves <palves@redhat.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: Tom Tromey <tromey@redhat.com>, Keith Seitz <keiths@redhat.com>,
Eli Zaretskii <eliz@gnu.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2] GDB/testsuite: Add a way to send multiple init commands
Date: Thu, 10 Jul 2014 16:15:00 -0000 [thread overview]
Message-ID: <53BEBC02.20208@redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1407100100210.16254@tp.orcam.me.uk>
On 07/10/2014 01:17 AM, Maciej W. Rozycki wrote:
> On Fri, 20 Jun 2014, Pedro Alves wrote:
>
>>> 2014-06-11 Maciej W. Rozycki <macro@mips.com>
>>> Maciej W. Rozycki <macro@codesourcery.com>
>>>
>>> * lib/gdb.exp (gdb_run_cmd): Process `gdb_init_commands'.
>>> * lib/mi-support.exp (mi_run_cmd): Process `gdb_init_commands'.
>>> * README (Board Settings): Document `gdb_init_command' and
>>> `gdb_init_commands'.
>>
>> I don't particularly see much need for this -- I do this in my
>> boards instead:
>>
>> set GDBFLAGS ""
>> set GDBFLAGS "${GDBFLAGS} -ex \"set breakpoint always-inserted on\""
>> set GDBFLAGS "${GDBFLAGS} -ex \"set target-async 1\""
>>
>> See:
>>
>> https://sourceware.org/gdb/wiki/TestingGDB#Passing_an_option_to_GDB_.2BAC8_Running_the_whole_test_suite_in_a_non-default_mode
>>
>> But, given gdb_init_command exists and this can be made
>> non-intrusive, it's fine with me to add the new option.
>
> That and I think there are two issues with passing commands as
> command-line arguments:
>
> 1. They are always executed, perhaps unnecessarily whereas
> `gdb_init_command' and consequently `gdb_init_commands' are only
> interpreted when a target connection is about to be made (this is more
> of an aesthetic matter, but still).
Which I'll guess is an historic accident (not by design) given the
option's name. I'd think hooking gdb_reload/gdb_load would do just
as well.
>
> 2. Some environments have a limit, maybe quite low, on the maximum length
> of a command line or command-line arguments they accept (now that is
> more real).
Not really an issue, as you can just put the commands in a GDB script
and do:
set GDBFLAGS "${GDBFLAGS} -x \"/path/to/script.gdb\""
Very much like a response file.
>
> BTW, in updating DejaGNU documentation that refers to `gdb_init_command'
> I've noticed it lists a command that pokes at a CPU register there -- has
> the semantics of the setting changed sometime, perhaps long ago? Does
> anybody know/remember?
I don't know the history, but I'd guess it's related to
this in config/gdb-comm.exp (found in dejagnu itself, not
gdb):
#
# gdb_comm_load -- load the program and execute it
#
# PROG is a full pathname to the file to load, no arguments.
# Result is "untested", "pass", "fail", etc.
#
proc gdb_comm_load { dest prog args } {
...
remote_send host "target $protocol $targetname\n"
remote_expect host 60 {
...
if {[target_info exists gdb_init_command]} {
remote_send host "[target_info gdb_init_command]\n"
remote_expect host 10 {
-re ".*$gdb_prompt $" { }
default {
gdb_comm_leave
return [list "fail" ""]
}
}
}
...
}
So in that board, gdb_init_command runs after connecting, and
is used to configure the board after connecting. Clearly there's
a usage conflict here...
(that's a ${board}_load override, note.)
I'd guess most of what's in that file predates all the equivalent
infrastructure we have, even. Maybe gdb_init_command started out
there before in appeared in gdb's codebase. But that's just
guesswork. I wasn't around then. :-) I have no idea if gdb-comm.exp
is still used.
> Done, as below, and retested. Any other questions or comments?
> Otherwise OK to apply?
This version looks good to me.
Thanks,
--
Pedro Alves
next prev parent reply other threads:[~2014-07-10 16:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 18:24 [PATCH] " Maciej W. Rozycki
2014-06-10 18:52 ` Keith Seitz
2014-06-11 15:39 ` Tom Tromey
2014-06-11 18:41 ` Maciej W. Rozycki
2014-06-19 23:39 ` [PING][PATCH] " Maciej W. Rozycki
2014-06-20 7:14 ` Eli Zaretskii
2014-06-20 22:53 ` Maciej W. Rozycki
2014-06-21 7:14 ` Eli Zaretskii
2014-06-23 14:03 ` Joel Brobecker
2014-06-20 8:50 ` [PATCH] " Pedro Alves
2014-07-10 0:17 ` [PATCH v2] " Maciej W. Rozycki
2014-07-10 16:15 ` Pedro Alves [this message]
2014-07-12 4:38 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BEBC02.20208@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=macro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).