From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26843 invoked by alias); 17 Jul 2014 14:13:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26826 invoked by uid 89); 17 Jul 2014 14:13:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 17 Jul 2014 14:13:53 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6HEDpfI002556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 17 Jul 2014 10:13:52 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6HEDo1p021459; Thu, 17 Jul 2014 10:13:50 -0400 Message-ID: <53C7DA1D.6090302@redhat.com> Date: Thu, 17 Jul 2014 14:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] rewrite make-target-delegates matching code References: <1405522205-4768-1-git-send-email-tromey@redhat.com> In-Reply-To: <1405522205-4768-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00466.txt.bz2 Hi Tom, On 07/16/2014 03:50 PM, Tom Tromey wrote: > This patch rewrites the make-target-delegates matching code a little > bit. The result is functionally the same (the output has some small > whitespace differences), but the new code is more forgiving regarding > the formatting of target.h. In particular now there's no need to > ensure that the return type and the method name appear on the same > line. Looks fine to me. Thanks, -- Pedro Alves