public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] make "set debug target" take effect immediately
@ 2014-07-28 19:18 Tom Tromey
  2014-07-28 19:21 ` Eli Zaretskii
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Tom Tromey @ 2014-07-28 19:18 UTC (permalink / raw)
  To: gdb-patches; +Cc: Tom Tromey

Right now, "set debug target" acts a bit strangely.

Most target APIs only notice that it has changed when the target stack
is changed in some way.  This is because many methods implement the
setting using the special debug target.  However, a few spots do
change their behavior immediately -- any place explicitly checking
"targetdebug".

Some of this peculiar behavior is documented.  However, I think that
it just isn't very useful for it to work this way.  So, This patch
changes "set debug target" to take effect immediately in all cases.
This is done by simply calling update_current_target when the setting
is changed.

This required one small change in the test suite.  Here a test was
expecting the current behavior.

Built and regtested on x86-64 Fedora 20.

2014-07-28  Tom Tromey  <tromey@redhat.com>

	* target.c (set_targetdebug): New function.
	(initialize_targets): Pass set_targetdebug when creating "set
	debug target".

2014-07-28  Tom Tromey  <tromey@redhat.com>

	* gdb.texinfo (Debugging Output): Update for change to "set debug
	target".

2014-07-28  Tom Tromey  <tromey@redhat.com>

	* gdb.base/sss-bp-on-user-bp-2.exp: Expect output from "set debug
	target 0".
---
 gdb/ChangeLog                                  |  6 ++++++
 gdb/doc/ChangeLog                              |  5 +++++
 gdb/doc/gdb.texinfo                            |  3 +--
 gdb/target.c                                   | 11 ++++++++++-
 gdb/testsuite/ChangeLog                        |  5 +++++
 gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp |  2 +-
 6 files changed, 28 insertions(+), 4 deletions(-)

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 32f709a..8d9148c 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -22996,8 +22996,7 @@ Show the current state of symbol table creation debugging.
 Turns on or off display of @value{GDBN} target debugging info. This info
 includes what is going on at the target level of GDB, as it happens. The
 default is 0.  Set it to 1 to track events, and to 2 to also track the
-value of large memory transfers.  Changes to this flag do not take effect
-until the next time you connect to a target or use the @code{run} command.
+value of large memory transfers.
 @item show debug target
 Displays the current state of displaying @value{GDBN} target debugging
 info.
diff --git a/gdb/target.c b/gdb/target.c
index d9b471b..a54494f 100644
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -120,6 +120,8 @@ static void init_dummy_target (void);
 
 static void debug_to_open (char *, int);
 
+static void update_current_target (void);
+
 /* Pointer to array of target architecture structures; the size of the
    array; the current index into the array; the allocated size of the
    array.  */
@@ -175,6 +177,13 @@ int may_stop = 1;
 /* Non-zero if we want to see trace of target level stuff.  */
 
 static unsigned int targetdebug = 0;
+
+static void
+set_targetdebug  (char *args, int from_tty, struct cmd_list_element *c)
+{
+  update_current_target ();
+}
+
 static void
 show_targetdebug (struct ui_file *file, int from_tty,
 		  struct cmd_list_element *c, const char *value)
@@ -3556,7 +3565,7 @@ Show target debugging."), _("\
 When non-zero, target debugging is enabled.  Higher numbers are more\n\
 verbose.  Changes do not take effect until the next \"run\" or \"target\"\n\
 command."),
-			     NULL,
+			     set_targetdebug,
 			     show_targetdebug,
 			     &setdebuglist, &showdebuglist);
 
diff --git a/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp b/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp
index a196f68..dd793bd 100644
--- a/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp
+++ b/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp
@@ -76,7 +76,7 @@ if { $hardware_step } {
     return
 }
 
-gdb_test_no_output "set debug target 0"
+gdb_test "set debug target 0" "->to_log_command.*\\)"
 
 set line_re "\[^\r\n\]*"
 
-- 
1.9.3

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-08-04 14:09 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-28 19:18 [PATCH] make "set debug target" take effect immediately Tom Tromey
2014-07-28 19:21 ` Eli Zaretskii
2014-07-28 19:34   ` Eli Zaretskii
2014-07-28 20:51   ` Tom Tromey
2014-08-04 14:09     ` Tom Tromey
2014-07-29 10:07 ` Yao Qi
2014-07-29 10:27   ` Pedro Alves
2014-07-29 20:05   ` Tom Tromey
2014-07-30  7:48     ` Yao Qi
2014-07-30 13:49       ` Tom Tromey
2014-08-04 14:09         ` Tom Tromey
2014-07-29 11:05 ` Pedro Alves

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).