From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90874 invoked by alias); 6 Nov 2019 16:31:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90598 invoked by uid 89); 6 Nov 2019 16:30:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Received:sk:r12mr32, our, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Nov 2019 16:30:54 +0000 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 779E6368E4 for ; Wed, 6 Nov 2019 16:30:53 +0000 (UTC) Received: by mail-wr1-f69.google.com with SMTP id f8so11629283wrq.6 for ; Wed, 06 Nov 2019 08:30:53 -0800 (PST) Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id y19sm4175000wmd.29.2019.11.06.08.30.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Nov 2019 08:30:51 -0800 (PST) Subject: Re: [review] Add gdb_compile_openmp to lib/gdb.exp To: Simon Marchi , Kevin Buettner , gdb-patches@sourceware.org References: <20191106162415.D0CBD25B28@gnutoolchain-gerrit.osci.io> <43214671-df5a-767e-39cc-cc0af512d85e@polymtl.ca> Cc: Tom Tromey From: Pedro Alves Message-ID: <53a5f406-eb17-ba39-8168-0bcb161759b3@redhat.com> Date: Wed, 06 Nov 2019 16:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <43214671-df5a-767e-39cc-cc0af512d85e@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-11/txt/msg00173.txt.bz2 [gerrit removed] On 11/6/19 4:26 PM, Simon Marchi wrote: > On 2019-11-06 11:24 a.m., Pedro Alves (Code Review) wrote: >>>> (I wanted to select all lines from 5930 to 5961 to show the whole context in the email notificatio […] >> >> Nice, that worked! I think it would be a good idea to mention this in our Gerrit wiki, to invite/remind people do this? > > Sure! > > (This is sent as an email to test replying to comments by email) The handling for TABs makes the indentation levels hard to follow, though: https://sourceware.org/ml/gdb-patches/2019-11/msg00168.html Should the email notification replace tabs with 8 spaces? Thanks, Pedro Alves