From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 2/2] Add dprintf and detach test (PR breakpoints/17012)
Date: Thu, 04 Sep 2014 18:37:00 -0000 [thread overview]
Message-ID: <5408B159.20203@ericsson.com> (raw)
In-Reply-To: <54089744.2030702@redhat.com>
On 14-09-04 12:45 PM, Pedro Alves wrote:
> On 08/22/2014 08:05 PM, Simon Marchi wrote:
>
>
>> Until the remote case is sorted out, would it be ok to disable the
>> test for all remote targets or KFAIL the tests? I will tackle the
>> blocking problems in separate patches.
>
> Sure.
I am not sure how to do this though. Is this ok?
# Disable this test when using gdb for now (the inferior crashes when
# detaching due to PR 17302).
set test "re-attach to inferior"
if ![gdb_is_target_remote] {
# Give some time for the ex-inferior to run and hopefully not crash.
sleep 1
gdb_test "attach $inferior_pid" "Attaching to program: $escapedbinfile, process $inferior_pid.*Reading symbols from.*" "$test"
} else {
kfail "breakpoints/17302" "$test"
}
I know that "remote" does not necessarily means gdbserver, but I don't
know how to check for gdbserver specifically. I put the sleep in the condition
so we don't waste time for nothing if we are not going to run the test anyway.
> This is OK otherwise.
>
> Though please push the test and fix as a single commit.
>
> Thanks,
> Pedro Alves
>
next prev parent reply other threads:[~2014-09-04 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 19:05 [PATCH v3 1/2] Only leave dprintf inserted if it is marked as persistent " Simon Marchi
2014-08-22 19:05 ` [PATCH v3 2/2] Add dprintf and detach test " Simon Marchi
2014-09-04 16:46 ` Pedro Alves
2014-09-04 18:37 ` Simon Marchi [this message]
2014-09-05 15:41 ` Pedro Alves
2014-12-10 21:14 ` Simon Marchi
2014-09-02 14:13 ` [PATCH v3 1/2] Only leave dprintf inserted if it is marked as persistent " Simon Marchi
2014-09-04 16:45 ` Pedro Alves
2014-09-04 18:33 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5408B159.20203@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).