From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19521 invoked by alias); 4 Sep 2014 18:37:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19511 invoked by uid 89); 4 Sep 2014 18:37:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 04 Sep 2014 18:37:16 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id EE.0D.25146.0C958045; Thu, 4 Sep 2014 14:23:28 +0200 (CEST) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.93) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 4 Sep 2014 14:37:14 -0400 Message-ID: <5408B159.20203@ericsson.com> Date: Thu, 04 Sep 2014 18:37:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH v3 2/2] Add dprintf and detach test (PR breakpoints/17012) References: <1408734315-21207-1-git-send-email-simon.marchi@ericsson.com> <1408734315-21207-2-git-send-email-simon.marchi@ericsson.com> <54089744.2030702@redhat.com> In-Reply-To: <54089744.2030702@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00129.txt.bz2 On 14-09-04 12:45 PM, Pedro Alves wrote: > On 08/22/2014 08:05 PM, Simon Marchi wrote: > > >> Until the remote case is sorted out, would it be ok to disable the >> test for all remote targets or KFAIL the tests? I will tackle the >> blocking problems in separate patches. > > Sure. I am not sure how to do this though. Is this ok? # Disable this test when using gdb for now (the inferior crashes when # detaching due to PR 17302). set test "re-attach to inferior" if ![gdb_is_target_remote] { # Give some time for the ex-inferior to run and hopefully not crash. sleep 1 gdb_test "attach $inferior_pid" "Attaching to program: $escapedbinfile, process $inferior_pid.*Reading symbols from.*" "$test" } else { kfail "breakpoints/17302" "$test" } I know that "remote" does not necessarily means gdbserver, but I don't know how to check for gdbserver specifically. I put the sleep in the condition so we don't waste time for nothing if we are not going to run the test anyway. > This is OK otherwise. > > Though please push the test and fix as a single commit. > > Thanks, > Pedro Alves >