From: Pedro Alves <palves@redhat.com>
To: Adrian Sendroiu <adrian.sendroiu@freescale.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 2/2] mi-out: Implement mi redirection using a stack.
Date: Fri, 05 Sep 2014 16:06:00 -0000 [thread overview]
Message-ID: <5409DF94.9050904@redhat.com> (raw)
In-Reply-To: <53E0E251.7040803@freescale.com>
Hi Adrian,
On 08/05/2014 02:55 PM, Adrian Sendroiu wrote:
>> It's better to use $bpnum instead of hardcoding 2, as otherwise if someone adds a
>> test that adds another breakpoint before this, this test stops being
>> effective, silently.
>
> done
>
>>> + mi_gdb_test "-exec-continue" ".*"
>>
>> This should use mi_send_resuming_command/mi_expect_stop
>> or mi_execute_to, so that the test works when the whole MI
>> testsuite is run in async mode.
>
> done. Although I ran into another problem here, because mi_expect_stop expects a
> message that looks like *stopped + prompt, while in my case it was something like
> *stopped + =breakpoint-modified + prompt. I solved this by doing an even simpler
> test case: just executing two python commands nested inside one another, like
> "python gdb.execute('python gdb.execute(...".
>
>
>> I think that we can avoid this duplication by renaming
>> skip_python_tests, adding it a prompt_re parameter, and
>> using that instead of $gdb_prompt. Something like:
>>
>> proc skip_python_tests {} {
>> skip_python_tests_prompt "$gdb_prompt $"
>> }
>>
>> proc mi_skip_python_tests {
>> skip_python_tests_prompt "$mi_gdb_prompt$"
>> }
>>
>> Did you try that?
>
> done
>
Thanks.
I'm getting these with this patch:
Running /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.mi/mi-logging.exp ...
PASS: gdb.mi/mi-logging.exp: breakpoint at main
PASS: gdb.mi/mi-logging.exp: mi runto main
PASS: gdb.mi/mi-logging.exp: logging on
PASS: gdb.mi/mi-logging.exp: logged step
PASS: gdb.mi/mi-logging.exp: logged next
ERROR: Got interactive prompt.
UNRESOLVED: gdb.mi/mi-logging.exp: logging off
PASS: gdb.mi/mi-logging.exp: Log file contents
ERROR: Got interactive prompt.
UNRESOLVED: gdb.mi/mi-logging.exp: redirect logging on
ERROR: Got interactive prompt.
UNRESOLVED: gdb.mi/mi-logging.exp: redirect logging off
FAIL: gdb.mi/mi-logging.exp: Redirect log file contents
FAIL: gdb.mi/mi-logging.exp: verify python support (GDB internal error)
ERROR: Could not resync from internal error (timeout)
UNRESOLVED: gdb.mi/mi-logging.exp: check if python 3 (got interactive prompt)
ERROR: tcl error sourcing /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.mi/mi-logging.exp.
ERROR: can't read "gdb_py_is_py3k": no such variable
while executing
...
gdb.log shows:
Expecting: ^(-gdb-set logging off[
]+)?(.*[
]+[(]gdb[)]
[ ]*)
-gdb-set logging off
^done~"/home/pedro/gdb/mygit/src/gdb/mi/mi-out.c:398: internal-error: VEC_ui_filep_last: Assertion `last' failed.\nA problem internal to GDB has been detected,\nfurther deb
ugging may prove unreliable.\nQuit this debugging session? "
~"(y or n) "
ERROR: Got interactive prompt.
UNRESOLVED: gdb.mi/mi-logging.exp: logging off
PASS: gdb.mi/mi-logging.exp: Log file contents
Expecting: ^(-gdb-set logging redirect on[
]+)?(.*[
]+[(]gdb[)]
[ ]*)
Any idea what went wrong ?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-09-05 16:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 14:26 [PATCH 0/2] Reimplement redirection for MI Adrian Sendroiu
2014-07-23 14:26 ` [PATCH 2/2] mi-out: Implement mi redirection using a stack Adrian Sendroiu
2014-07-24 20:34 ` Tom Tromey
2014-07-25 11:43 ` [PATCH v2 " Adrian Sendroiu
2014-07-29 15:16 ` Pedro Alves
2014-07-30 8:38 ` Adrian Sendroiu
2014-07-30 12:05 ` Pedro Alves
2014-07-31 16:23 ` Adrian Sendroiu
2014-07-31 17:11 ` Pedro Alves
2014-08-05 13:54 ` Adrian Sendroiu
2014-08-28 11:33 ` Adrian Sendroiu
2014-09-05 16:06 ` Pedro Alves [this message]
2014-09-07 15:45 ` Adrian Sendroiu
2014-09-08 13:19 ` Pedro Alves
2014-09-08 18:59 ` Sergio Durigan Junior
2014-09-09 14:03 ` Adrian Sendroiu
2014-09-26 9:25 ` Adrian Sendroiu
2014-09-26 12:51 ` Pedro Alves
2014-07-23 14:37 ` [PATCH 1/2] cli/cli-logging.c: don't call ui_out_redirect for MI when disabling logging Adrian Sendroiu
2014-07-24 18:19 ` Tom Tromey
2015-08-17 18:47 ` [PATCH 0/2] Reimplement redirection for MI Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5409DF94.9050904@redhat.com \
--to=palves@redhat.com \
--cc=adrian.sendroiu@freescale.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).