From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11016 invoked by alias); 10 Sep 2014 13:31:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10965 invoked by uid 89); 10 Sep 2014 13:31:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_20,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: qmta11.emeryville.ca.mail.comcast.net Received: from qmta11.emeryville.ca.mail.comcast.net (HELO qmta11.emeryville.ca.mail.comcast.net) (76.96.27.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Sep 2014 13:31:37 +0000 Received: from omta24.emeryville.ca.mail.comcast.net ([76.96.30.92]) by qmta11.emeryville.ca.mail.comcast.net with comcast id pRTV1o0011zF43QABRXayp; Wed, 10 Sep 2014 13:31:36 +0000 Received: from redwood.eagercon.com ([24.7.16.38]) by omta24.emeryville.ca.mail.comcast.net with comcast id pRXZ1o00D0pGQcg8kRXZd1; Wed, 10 Sep 2014 13:31:34 +0000 Message-ID: <541052B5.5080503@eagercon.com> Date: Wed, 10 Sep 2014 13:31:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ajit Kumar Agarwal , "gdb-patches@sourceware.org" CC: Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch, microblaze]: Port of Linux gdbserver References: <2570e3c7-f55b-45cd-aa6e-7f4fa145f32a@BN1BFFO11FD002.protection.gbl> In-Reply-To: <2570e3c7-f55b-45cd-aa6e-7f4fa145f32a@BN1BFFO11FD002.protection.gbl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00305.txt.bz2 On 09/10/14 03:14, Ajit Kumar Agarwal wrote: > Please find the patch for the Linux gdbserver port for Microblaze. > > [Patch, microblaze]: Port of Linux gdbserver > > This patch is the port of Linux gdbserver. > > ChangeLog: > 2014-10-09 Ajit Agarwal > > * microblaze-tdep.h (MICROBLAZE_BREAKPOINT): New Macro. > (MICROBLAZE_BREAKPOINT_LE): New Macro. > * microblaze-linux-tdep.c > (microblaze_linux_memory_remove_breakpoint): Use of > set_gdbarch_fetch_tls_load_module_address, do_cleanup. > * configure.host (microblaze): New. > (microblaze*-*-linux*): New. > * configure.tgt (build_gdbserver): New Definition. > * gdbserver/Makefile.in (microblaze-linux.c): New target. > * gdbserver/configure.srv (microblaze*-*-linux*): New target. > * gdbserver/linux-microblaze-low.c: New file. > > Signed-off-by:Ajit Agarwal ajitkum@xilinx.com > > Thanks & Regards Please follow GNU coding conventions: + if (microblaze_regmap[regno] == -1 || regno == 0) + return 1; + + return 0; No indent. +/* dbtrap insn */ +/* brki r16, 0x18; */ Remove cruft. + if (regno == 0) + { + unsigned long regbuf_0 = 0; + /* Clobbering r0 so that it is always 0 as enforced by hardware. */ + supply_register (regcache, regno, (const char*)®buf_0); + } else { Indent. + for (i = 0; i < microblaze_num_regs; i++) + microblaze_collect_ptrace_register (regcache, i, (char *) buf + microblaze_regmap[i]); Break lines before 80 cols. +static struct regsets_info microblaze_regsets_info = { + + microblaze_regsets, /* regsets */ + 0, /* num_regsets */ + NULL, /* disabled_regsets */ +}; Remove blank line. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077