From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3243 invoked by alias); 10 Sep 2014 14:39:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3185 invoked by uid 89); 10 Sep 2014 14:39:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: resqmta-po-12v.sys.comcast.net Received: from resqmta-po-12v.sys.comcast.net (HELO resqmta-po-12v.sys.comcast.net) (96.114.154.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 10 Sep 2014 14:39:29 +0000 Received: from omta23.emeryville.ca.mail.comcast.net ([76.96.30.90]) by resqmta-po-12v.sys.comcast.net with comcast id pSMe1o0021wfjNs01SfHCe; Wed, 10 Sep 2014 14:39:17 +0000 Received: from redwood.eagercon.com ([24.7.16.38]) by omta23.emeryville.ca.mail.comcast.net with comcast id pSfG1o00e0pGQcg8jSfH8B; Wed, 10 Sep 2014 14:39:17 +0000 Message-ID: <54106294.8030806@eagercon.com> Date: Wed, 10 Sep 2014 14:39:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ajit Kumar Agarwal , Joel Brobecker CC: "gdb-patches@sourceware.org" , Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch, microblaze]: Port of Linux gdbserver References: <2570e3c7-f55b-45cd-aa6e-7f4fa145f32a@BN1BFFO11FD002.protection.gbl> <541052B5.5080503@eagercon.com> <20140910134606.GO28404@adacore.com> <050c6461-c35c-441d-9b63-7636d9164e2e@BL2FFO11FD048.protection.gbl> In-Reply-To: <050c6461-c35c-441d-9b63-7636d9164e2e@BL2FFO11FD048.protection.gbl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00313.txt.bz2 On 09/10/14 07:22, Ajit Kumar Agarwal wrote: > Please find the updated patch with review feedbacks are incorporated. > > [Patch, microblaze]: Port of Linux gdbserver > > This patch is the port of Linux gdbserver. > > ChangeLog: > 2014-10-09 Ajit Agarwal > > * configure.host (microblaze): New. > (microblaze*-*-linux*): New. > * configure.tgt (build_gdbserver): New Definition. > * gdbserver/Makefile.in (microblaze-linux.c): New target. > * gdbserver/configure.srv (microblaze*-*-linux*): New target. > * gdbserver/linux-microblaze-low.c: New file. > > Signed-off-by:Ajit Agarwal ajitkum@xilinx.com Please review your patches before you (re)submit them. + /* If necessary, recognize more trap instructions here. GDB only uses the + one. */ One line. + else + { + if (size < sizeof (long)) + supply_register (regcache, regno, buf + sizeof (long) - size); + else + supply_register (regcache, regno, buf); + } +} Fix indent. +static struct usrregs_info microblaze_usrregs_info = +{ + microblaze_num_regs, + microblaze_regmap, +}; Fix indent. How has this been tested? Please be specific. Did you rebuild and test after making changes to the patch? -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077