From: Hannes Domani <ssbssa@yahoo.de>
To: Tom Tromey <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Lancelot SIX <lsix@lancelotsix.com>
Subject: Re: [PATCH] Fix DLL export forwarding
Date: Wed, 6 Dec 2023 20:16:47 +0000 (UTC) [thread overview]
Message-ID: <5412544.4198.1701893807476@mail.yahoo.com> (raw)
In-Reply-To: <87ttovi0vu.fsf@tromey.com>
Am Mittwoch, 6. Dezember 2023, 20:31:20 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
> >>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:
>
> Hannes> I noticed it when I was trying to set a breakpoint at ExitProcess:
> ...
>
> Thank you for the patch.
>
> I have a couple of tiny nits, this is ok with those fixed -- you don't
> have to re-send it.
>
> You can also apply this to the gdb-14 branch if you want.
>
> Hannes> - unrelocated_addr vma = msymbol.minsym->unrelocated_address ();
> Hannes> + /* Calculate VMA as if if where relative to DLL_NAME/OBJFILE, even though
>
> s/if where/it were/
>
> Hannes> + it actually points inside another dll (FORWARD_DLL_NAME). */
> Hannes> + unrelocated_addr vma = unrelocated_addr(msymbol.value_address ()
>
> Space before the first "(".
>
> Approved-By: Tom Tromey <tom@tromey.com>
Thank you both Lancelot and Tom for noticing my typos.
They are fixed and it's pushed to both master and gdb-14-branch.
prev parent reply other threads:[~2023-12-06 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231204165029.408-1-ssbssa.ref@yahoo.de>
2023-12-04 16:50 ` Hannes Domani
2023-12-04 17:34 ` Lancelot SIX
2023-12-06 19:31 ` Tom Tromey
2023-12-06 20:16 ` Hannes Domani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5412544.4198.1701893807476@mail.yahoo.com \
--to=ssbssa@yahoo.de \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).