From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v4 3/3] Fix "breakpoint always-inserted off"; remove "breakpoint always-inserted auto"
Date: Mon, 22 Sep 2014 07:48:00 -0000 [thread overview]
Message-ID: <541FD33E.1050309@codesourcery.com> (raw)
In-Reply-To: <541E9E40.8070308@redhat.com>
On 09/21/2014 05:45 PM, Pedro Alves wrote:
> +void *
> +child_function_1 (void *arg)
> +{
> + volatile unsigned int counter = 1;
> +
> + pthread_barrier_wait (&barrier);
> +
> + while (counter > 0)
> + {
> + counter++;
> + usleep (1);
> +
> + if (!second_thread)
> + continue;
The code doesn't compile as second_thread isn't defined. Is it
second_child?
Otherwise, this patch looks good to me.
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-09-22 7:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 22:47 [PATCH v2 0/3] " Pedro Alves
2014-09-17 22:47 ` [PATCH v2 1/3] Change parameter type of update_global_location_list from boolean to enum Pedro Alves
2014-09-17 22:47 ` [PATCH v2 2/3] Tell update_global_location_list to insert breakpoints Pedro Alves
2014-09-17 22:47 ` [PATCH v2 3/3] Fix "breakpoint always-inserted off"; remove "breakpoint always-inserted auto" Pedro Alves
2014-09-18 1:49 ` Yao Qi
2014-09-19 19:05 ` [PATCH v3 " Pedro Alves
2014-09-21 9:45 ` [PATCH v4 " Pedro Alves
2014-09-22 7:48 ` Yao Qi [this message]
2014-09-22 9:13 ` Pedro Alves
2014-09-23 8:31 ` Regression for gdb.mi/mi-nsintrall.exp [Re: [PATCH v4 3/3] Fix "breakpoint always-inserted off"; remove "breakpoint always-inserted auto"] Jan Kratochvil
2014-09-23 16:27 ` Pedro Alves
2014-09-25 15:00 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541FD33E.1050309@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).