From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116064-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15960 invoked by alias); 22 Sep 2014 07:48:29 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 15945 invoked by uid 89); 22 Sep 2014 07:48:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Sep 2014 07:48:26 +0000
Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com)	by relay1.mentorg.com with esmtp 	id 1XVyMA-0004sn-Ex from Yao_Qi@mentor.com ; Mon, 22 Sep 2014 00:48:22 -0700
Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.181.6; Mon, 22 Sep 2014 00:48:21 -0700
Message-ID: <541FD33E.1050309@codesourcery.com>
Date: Mon, 22 Sep 2014 07:48:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.7.0
MIME-Version: 1.0
To: Pedro Alves <palves@redhat.com>
CC: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v4 3/3] Fix "breakpoint always-inserted off"; remove "breakpoint always-inserted auto"
References: <1410994028-24282-1-git-send-email-palves@redhat.com>	<1410994028-24282-4-git-send-email-palves@redhat.com> <87r3z9zopi.fsf@codesourcery.com> <541C7E77.6060704@redhat.com> <541E9E40.8070308@redhat.com>
In-Reply-To: <541E9E40.8070308@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
X-SW-Source: 2014-09/txt/msg00655.txt.bz2

On 09/21/2014 05:45 PM, Pedro Alves wrote:
> +void *
> +child_function_1 (void *arg)
> +{
> +  volatile unsigned int counter = 1;
> +
> +  pthread_barrier_wait (&barrier);
> +
> +  while (counter > 0)
> +    {
> +      counter++;
> +      usleep (1);
> +
> +      if (!second_thread)
> +	continue;

The code doesn't compile as second_thread isn't defined.  Is it
second_child?

Otherwise, this patch looks good to me.

-- 
Yao (齐尧)