From: Simon Marchi <simon.marchi@ericsson.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces"
Date: Wed, 24 Sep 2014 19:31:00 -0000 [thread overview]
Message-ID: <54231C1C.6060702@ericsson.com> (raw)
In-Reply-To: <87h9zwn93k.fsf@redhat.com>
On 2014-09-24 02:53 PM, Sergio Durigan Junior wrote:
>> @@ -385,7 +386,7 @@ maintenance_info_program_spaces_command (char *args, int from_tty)
>> error (_("program space ID %d not known."), requested);
>> }
>>
>> - print_program_space (current_uiout, requested);
>> + print_program_space (current_uiout, requested, 0 /* prune */);
>
> Just like we had a comment explaining why we were pruning progspaces, I
> think a small comment here explaining why we are *not* pruning them
> would be neat.
Sure, I could add to the current patch, above the call to print_program_space:
/* Since this is an "info" command, we want to avoid modifying
the state of the debugger. Therefore, don't prune unused
program spaces. */
next prev parent reply other threads:[~2014-09-24 19:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 18:11 Simon Marchi
2014-09-24 18:53 ` Sergio Durigan Junior
2014-09-24 19:31 ` Simon Marchi [this message]
2014-09-24 19:34 ` Sergio Durigan Junior
2014-09-24 22:48 ` Doug Evans
2014-09-25 2:31 ` Sergio Durigan Junior
2014-09-25 14:44 ` Simon Marchi
2014-09-25 19:13 ` Doug Evans
2014-09-26 14:37 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54231C1C.6060702@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).