From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11763 invoked by alias); 24 Sep 2014 19:31:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11748 invoked by uid 89); 24 Sep 2014 19:31:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 24 Sep 2014 19:31:44 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 95.C8.05330.6E5C2245; Wed, 24 Sep 2014 15:23:50 +0200 (CEST) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.84) with Microsoft SMTP Server (TLS) id 14.3.174.1; Wed, 24 Sep 2014 15:31:41 -0400 Message-ID: <54231C1C.6060702@ericsson.com> Date: Wed, 24 Sep 2014 19:31:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Sergio Durigan Junior CC: Subject: Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces" References: <1411582288-20967-1-git-send-email-simon.marchi@ericsson.com> <87h9zwn93k.fsf@redhat.com> In-Reply-To: <87h9zwn93k.fsf@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00715.txt.bz2 On 2014-09-24 02:53 PM, Sergio Durigan Junior wrote: >> @@ -385,7 +386,7 @@ maintenance_info_program_spaces_command (char *args, int from_tty) >> error (_("program space ID %d not known."), requested); >> } >> >> - print_program_space (current_uiout, requested); >> + print_program_space (current_uiout, requested, 0 /* prune */); > > Just like we had a comment explaining why we were pruning progspaces, I > think a small comment here explaining why we are *not* pruning them > would be neat. Sure, I could add to the current patch, above the call to print_program_space: /* Since this is an "info" command, we want to avoid modifying the state of the debugger. Therefore, don't prune unused program spaces. */