public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>, Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces"
Date: Thu, 25 Sep 2014 14:44:00 -0000	[thread overview]
Message-ID: <54242A52.8060200@ericsson.com> (raw)
In-Reply-To: <87sijgig81.fsf@redhat.com>

On 2014-09-24 10:30 PM, Sergio Durigan Junior wrote:
> On Wednesday, September 24 2014, Doug Evans wrote:
> 
>> IOW, how about move the call to prune_program_spaces to  whatever
>> caller wants it.
> 
> As a note, after I commented on the patch, I noticed that the "prune"
> argument may be unecessary indeed (and the "prunning" logic"), because
> we are not prunning anything anymore.
> 
> Anyway, I just wanted to say that I agree with removing this part of the
> code, and moving it to more suitable parts.

Fine with me. Here is the updated patch, much simpler now.

gdb/Changelog:

	* progspace.c (print_program_space): Don't prune program spaces
	before printing them.
---
 gdb/progspace.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gdb/progspace.c b/gdb/progspace.c
index a74b6ab..b111a50 100644
--- a/gdb/progspace.c
+++ b/gdb/progspace.c
@@ -281,10 +281,6 @@ print_program_space (struct ui_out *uiout, int requested)
   int count = 0;
   struct cleanup *old_chain;

-  /* Might as well prune away unneeded ones, so the user doesn't even
-     seem them.  */
-  prune_program_spaces ();
-
   /* Compute number of pspaces we will print.  */
   ALL_PSPACES (pspace)
     {
-- 
2.1.0

  reply	other threads:[~2014-09-25 14:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 18:11 Simon Marchi
2014-09-24 18:53 ` Sergio Durigan Junior
2014-09-24 19:31   ` Simon Marchi
2014-09-24 19:34     ` Sergio Durigan Junior
2014-09-24 22:48 ` Doug Evans
2014-09-25  2:31   ` Sergio Durigan Junior
2014-09-25 14:44     ` Simon Marchi [this message]
2014-09-25 19:13       ` Doug Evans
2014-09-26 14:37         ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54242A52.8060200@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).