From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9122 invoked by alias); 26 Sep 2014 14:37:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9107 invoked by uid 89); 26 Sep 2014 14:37:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 26 Sep 2014 14:37:01 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 56.38.25146.25125245; Fri, 26 Sep 2014 10:18:26 +0200 (CEST) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.87) with Microsoft SMTP Server (TLS) id 14.3.174.1; Fri, 26 Sep 2014 10:36:58 -0400 Message-ID: <542579FA.3040204@ericsson.com> Date: Fri, 26 Sep 2014 14:37:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Doug Evans CC: Sergio Durigan Junior , gdb-patches Subject: Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces" References: <1411582288-20967-1-git-send-email-simon.marchi@ericsson.com> <87sijgig81.fsf@redhat.com> <54242A52.8060200@ericsson.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00791.txt.bz2 On 2014-09-25 03:13 PM, Doug Evans wrote: > On Thu, Sep 25, 2014 at 8:44 AM, Simon Marchi wrote: >> On 2014-09-24 10:30 PM, Sergio Durigan Junior wrote: >>> On Wednesday, September 24 2014, Doug Evans wrote: >>> >>>> IOW, how about move the call to prune_program_spaces to whatever >>>> caller wants it. >>> >>> As a note, after I commented on the patch, I noticed that the "prune" >>> argument may be unecessary indeed (and the "prunning" logic"), because >>> we are not prunning anything anymore. >>> >>> Anyway, I just wanted to say that I agree with removing this part of the >>> code, and moving it to more suitable parts. >> >> Fine with me. Here is the updated patch, much simpler now. >> >> gdb/Changelog: >> >> * progspace.c (print_program_space): Don't prune program spaces >> before printing them. > > LGTM > > In the commit log I would add a note that this was removed so that the > print routine didn't have (unwanted) side-effects. > > Thanks. Pushed, thanks!