From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31898 invoked by alias); 30 Sep 2014 14:04:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31888 invoked by uid 89); 30 Sep 2014 14:04:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Sep 2014 14:04:40 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1XYy2f-0003ik-Pq from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Tue, 30 Sep 2014 07:04:37 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.181.6; Tue, 30 Sep 2014 07:04:37 -0700 Message-ID: <542AB77C.2050202@codesourcery.com> Date: Tue, 30 Sep 2014 14:04:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Subject: Re: [PATCH 0/3] Fix fails in gdb.mi on arm-none-eabi References: <1409533072-6152-1-git-send-email-yao@codesourcery.com> <87vbolzqq9.fsf@codesourcery.com> In-Reply-To: <87vbolzqq9.fsf@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00894.txt.bz2 On 09/18/2014 09:01 AM, Yao Qi wrote: > Yao Qi writes: > >> This series fixes some fails in mi-var-child.exp and >> mi-var-display.exp, which are caused by printed symbol on address >> zero. One of them is fixed by "set print symbol" off, and that is >> what patch 1/3 does. Patch 2/3 is a refactor patch, which uses >> mi_varobj_update in tests to simplify them. >> >> The cause of the rest of fails is that function pointers are NULL, >> and they point to a code symbol _ftext on address zero. We can >> relax pattern to match both "0x0" and "0x0 <_ftext>", but I didn't >> fix it in this way. Instead, I explicitly assign function address >> to these function pointers, so the output becomes "$hex <$func_name>" >> on all the targets. See details in patch 3/3. >> >> The patch series is tested on x86_64-linux with native and gdbserver, >> and arm-none-eabi. > > Patch 1 is pushed in. Ping patch 2 and patch 3. > > https://sourceware.org/ml/gdb-patches/2014-09/msg00002.html > https://sourceware.org/ml/gdb-patches/2014-09/msg00003.html > Ping. -- Yao (齐尧)