From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30515 invoked by alias); 30 Sep 2014 18:43:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30503 invoked by uid 89); 30 Sep 2014 18:43:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Sep 2014 18:43:24 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1XZ2OP-0001E5-7G from Don_Breazeal@mentor.com ; Tue, 30 Sep 2014 11:43:21 -0700 Received: from [127.0.0.1] ([172.30.12.49]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 30 Sep 2014 11:43:20 -0700 Message-ID: <542AF9C8.3040305@codesourcery.com> Date: Tue, 30 Sep 2014 18:43:00 -0000 From: "Breazeal, Don" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 01/16 v2] Refactor native follow-fork References: <1407434395-19089-1-git-send-email-donb@codesourcery.com> <1408580964-27916-2-git-send-email-donb@codesourcery.com> <5409C69F.8030906@redhat.com> <540E41C5.2000600@codesourcery.com> <540EDFFE.4090703@redhat.com> <54132443.5060602@codesourcery.com> <5425ACBF.7080800@redhat.com> <54299FF8.7000205@codesourcery.com> <542A8C54.1070005@redhat.com> In-Reply-To: <542A8C54.1070005@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00908.txt.bz2 On 9/30/2014 3:56 AM, Pedro Alves wrote: > On 09/29/2014 07:07 PM, Breazeal, Don wrote: > >> The patch is standalone and I believe it has value independent >> of the rest of the series. > > Yes, agreed. > >> OK to push? > > Yes, please push. > >> +/* Handle changes to the inferior list based on the type of fork, >> + which process is being followed, and whether the other process >> + should be detached. On entry inferior_ptid must be the ptid of >> + the fork parent. At return inferior_ptid is the ptid of the >> + followed inferior. */ >> + >> +int > > 'static int' here too. > > Consider putting the function above its caller thus avoiding > the need for the other declaration at the top. > >> +follow_fork_inferior (int follow_child, int detach_fork) >> +{ > > Thanks, > Pedro Alves > Patch is pushed with changes. Thanks, --Don